Make tidy errors red #106286
Merged
Make tidy errors red #106286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-bootstrap
rustbot
added
the
S-waiting-on-review
Noratrieb
force-pushed
the
tidy-cowows
branch
from
c9d09ef
to
2790285
Compare
jyn514
reviewed
Dec 30, 2022
There was a problem hiding this comment.
before:
tidy check
Checking which error codes lack tests...
* 633 error codes
* highest error code: E0791
tidy error: /home/gh-jyn514/rust2/compiler/rustc_error_codes/src/error_codes/E0790.md: empty file
tidy error: /home/gh-jyn514/rust2/compiler/rustc_error_codes/src/error_codes/E0790.md: leading newline
* 393 features
`/home/gh-jyn514/rust2/compiler/rustc_error_codes/src/error_codes/E0790.md` doesn't use its own error code in compile_fail example
Found 1 error(s) in error codes
Done!
some tidy checks failed
after:
tidy check
* 633 error codes
* highest error code: E0791
tidy error: /home/gh-jyn514/rust2/compiler/rustc_error_codes/src/error_codes/E0790.md: empty file
tidy error: /home/gh-jyn514/rust2/compiler/rustc_error_codes/src/error_codes/E0790.md: leading newline
* 393 features
tidy error: `/home/gh-jyn514/rust2/compiler/rustc_error_codes/src/error_codes/E0790.md` doesn't use its own error code in compile_fail example
some tidy checks failed
The changes in text look reasonable, but I'm not seeing them show up as red? Am I missing something?
jyn514
added
S-waiting-on-author
Noratrieb
commented
Dec 30, 2022
Noratrieb
force-pushed
the
tidy-cowows
branch
from
2790285
to
a078c4d
Compare
jyn514
reviewed
Dec 30, 2022
This makes it easier to see them (and makes people go owo).
Noratrieb
force-pushed
the
tidy-cowows
branch
from
a078c4d
to
75b3ee2
Compare
|
Looks great, thanks! r=me with CI passing :) |
jyn514
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
Make tidy errors red This makes it easier to see them (and makes people go owo). I also changes the error codes check to not print too many things and use `tidy_error`. r? `@jyn514`
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
Dec 31, 2022
Make tidy errors red This makes it easier to see them (and makes people go owo). I also changes the error codes check to not print too many things and use `tidy_error`. r? ``@jyn514``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2022
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#105903 (Unify id-based thread parking implementations) - rust-lang#106232 (CFI: Monomorphize transparent ADTs before typeid) - rust-lang#106248 (Revert "Implement allow-by-default `multiple_supertrait_upcastable` lint") - rust-lang#106286 (Make tidy errors red) - rust-lang#106295 (Extend scraped examples layout GUI test for position of buttons) - rust-lang#106305 ( bootstrap: Get rid of tail_args in stream_cargo) - rust-lang#106310 (Dont use `--merge-base` during bootstrap formatting subcommand) - rust-lang#106314 (Fix panic on `x build --help`) - rust-lang#106317 (Only deduplicate stack traces for good path bugs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to see them (and makes people go owo).
I also changes the error codes check to not print too many things and use
tidy_error.r? @jyn514