Rollup of 8 pull requests #106565
Closed
Rollup of 8 pull requests #106565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test process-panic-after-fork.rs was checking that abort() resulted in SIGSEGV on Android. This non-standard behavior was fixed back in 2013, so let's fix the test to also accept the standard behavior on Android.
WIP - replacing span_invalid_monomorphization_error function. Still in progress due to its use in codegen_llvm inside macros
UPDATE - migrate constant span_bug to translatable diagnostic.
This rule was added to override non-zero left margin on `.content`, which was removed in 135281e and the margin-left was put on the docblock.
Signed-off-by: Yuki Okushi <[email protected]>
…ompiler-errors Migrating rustc_infer to session diagnostics (part 3) `@rustbot` label +A-translation r? rust-lang/diagnostics cc rust-lang#100717 Seems like a part of static_impl_trait.rs emits suggestions in a loop, and note.rs needs to have two instances of the same subdiagnostic, so these will need to wait until we have eager translation/list support. Other than that, there is only error_reporting/mod.rs left to migrate.
…-diagnostics-structs-pt3, r=davidtwco Migrate `codegen_ssa` to diagnostics structs - [Part 3] Completes migrating `codegen_ssa` module except 2 outstanding errors that depend on other crates: 1. [`rustc_middle::mir::interpret::InterpError`](https://github.com/rust-lang/rust/blob/b6097f2e1b2ca62e188ba53cf43bd66b06b36915/compiler/rustc_middle/src/mir/interpret/error.rs#L475): I saw `rustc_middle` is unassigned, I am open to take this work. 2. `codegen_llvm`'s use of `fn span_invalid_monomorphization_error`, which I started to replace in the [last commit](rust-lang@9a31b3c) of this PR, but would like to know the team's preference on how we should keep replacing the other macros: 2.1. Update macros to expect a `Diagnostic` 2.2. Remove macros and expand the code on each use. See [some examples of the different options in this experimental commit](JhonnyBillM@64aee83) _Part 2 - https://github.com/rust-lang/rust/pull/103792_ r? `@davidtwco` Cc `@compiler-errors`
…vidtwco Fix process-panic-after-fork.rs to pass on newer versions of Android. The test process-panic-after-fork.rs was checking that abort() resulted in SIGSEGV on Android. This non-standard behavior was fixed back in 2013, so let's fix the test to also accept the standard behavior on Android.
…=davidtwco Point out span where we could introduce higher-ranked lifetime Somewhat addresses rust-lang#105422, but not really. We don't have that much useful information here since we're still in resolution :^( Maybe this suggestion isn't worth it. If the reviewer has an idea how we can get a more succinct binder information for a structured suggestion, it would be appreciated.
…-errors Add regression test for rust-lang#100772 Closes rust-lang#100772 r? `@compiler-errors` Signed-off-by: Yuki Okushi <[email protected]>
…twco Detect closures assigned to binding in block Fix rust-lang#58497.
…hnTitor docs: make `HashSet::retain` doctest more clear Fixes rust-lang#106535 Extremely simple fix suggested by `@compiler-errors` in the linked issue.
…ntent-mobile, r=GuillaumeGomez
rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`
This rule was added to override non-zero left margin on `.content`, which was removed in 135281e and the margin-left was put on the docblock.
rustbot
added
T-bootstrap
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 9639646 with merge 5279c6014ab7c8ba2147bb05a61ed09c48689c0a... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
codegen_ssato diagnostics structs - [Part 3] #104543 (Migratecodegen_ssato diagnostics structs - [Part 3])Param(T/#0)#100772)HashSet::retaindoctest more clear #106553 (docs: makeHashSet::retaindoctest more clear).content { margin-left: 0 }#106556 (rustdoc: remove no-op mobile CSS.content { margin-left: 0 })Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup