Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent E0512 from emitting [type error] by checking the references_error #106784

Merged
merged 1 commit into from
Jan 18, 2023
Merged

prevent E0512 from emitting [type error] by checking the references_error #106784

merged 1 commit into from
Jan 18, 2023

Conversation

lyming2007
Copy link

@lyming2007 lyming2007 commented Jan 12, 2023 •
edited by compiler-errors
Loading

but still emit E0512
this will fix #106695

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 12, 2023
@compiler-errors compiler-errors changed the title prevent E0512 from emitting [type error] by checking the references_e… prevent E0512 from emitting [type error] by checking the references_error Jan 12, 2023
@WaffleLapkin
Copy link
Member

WaffleLapkin commented Jan 12, 2023 •
edited
Loading

Shouldn't this do the same as #106499, downgrade to bug if the type references error? In these tests I don't see how these diagnostics help.

(btw, please don't mention issues and prs with # and urls in commit messages, this pollutes the discussions with mentions, especially when the pr is rolled up)

@lyming2007
Copy link
Author

Shouldn't this do the same as #106499, downgrade to bug if the type references error? In these tests I don't see how these diagnostics help.
For #105946, neither the E0029 nor the E0277 should have been emitted. But for this error E0512 is supposed to emit, but [type error] should emit

(btw, please don't mention issues and prs with # and urls in commit messages, this pollutes the discussions with mentions, especially when the pr is rolled up)

Thanks for your suggestion. I will do it later.

@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2023
@WaffleLapkin
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 17, 2023

📌 Commit d1478a5 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
@bors
Auto merge of rust-lang#106998 - matthiaskrgr:rollup-hmfisji, r=matth…
edefa41 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104505 (Remove double spaces after dots in comments)
 - rust-lang#106784 (prevent E0512 from emitting [type error] by checking the references_error)
 - rust-lang#106834 (new trait solver: only consider goal changed if response is not identity)
 - rust-lang#106889 (Mention the lack of `windows_mut` in `windows`)
 - rust-lang#106963 (Use `scope_expr_id` from `ProbeCtxt`)
 - rust-lang#106970 (Switch to `EarlyBinder` for `item_bounds` query)
 - rust-lang#106980 (Hide `_use_mk_alias_ty_instead` in `<AliasTy as Debug>::fmt`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4ee5e09 into rust-lang:master Jan 18, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 18, 2023
@lyming2007 lyming2007 deleted the issue-106695-fix branch January 18, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

size can vary because of [type error] in E0512
5 participants
@lyming2007 @rustbot @WaffleLapkin @bors @compiler-errors