Rollup of 10 pull requests #106822

matthiaskrgr · 2023-01-13T18:16:47Z

Successful merges:

Add log-backtrace option to show backtraces along with logging #104645 (Add log-backtrace option to show backtraces along with logging)
Bump IMPLIED_BOUNDS_ENTAILMENT to Deny + ReportNow #106465 (Bump IMPLIED_BOUNDS_ENTAILMENT to Deny + ReportNow)
Fix linker detection for linker (drivers) with a version postfix (e.g. clang-12 instead of clang) #106489 (Fix linker detection for linker (drivers) with a version postfix (e.g. clang-12 instead of clang))
When suggesting writing a fully qualified path probe for appropriate types #106585 (When suggesting writing a fully qualified path probe for appropriate types)
Provide help on closures capturing self causing borrow checker errors #106641 (Provide help on closures capturing self causing borrow checker errors)
Warn when using panic-strategy abort for proc-macro crates #106678 (Warn when using panic-strategy abort for proc-macro crates)
Fix mpsc::SyncSender spinning behavior #106701 (Fix mpsc::SyncSender spinning behavior)
Normalize test output more thoroughly #106793 (Normalize test output more thoroughly)
riscv: Fix ELF header flags #106797 (riscv: Fix ELF header flags)
Remove redundant session field #106813 (Remove redundant session field)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This prevents differences in local environments, which may (for example) end up with a longer backtrace with more digits in the backtrace prefix, as happened to me. While we're at it, clean more of the output up, including the exact location of the error in the compiler.

The previous version added both `EF_RISCV_FLOAT_ABI_DOUBLE` and `EF_RISCV_RVC` if the "D" extension was enabled on riscv64 targets. riscv32 targets were not accounted for. This patch changes this so that: - Only add `EF_RISCV_RVC` if the "C" extension is enabled - Add `EF_RISCV_FLOAT_ABI_SINGLE` if the "F" extension is enabled and the "D" extension is not - Add these ELF flags for riscv32 as well

Linker drivers such as gcc, clang or lld often have a version postfix, e.g clang-12. The previous logic would not account for this and would fall back to guessing the linker flavor to be the default linker flavor for the target, which causes linker errors when this is not the case. By accounting for the possible version postfix and also considering g++ and clang++, we considerably reduce the amount of times the fallback guess has to be used. To simplify matching check for a version postfix and match against the linker stem without any version postfix. In contrast to gcc, clang supports all architectures in one binary. This means there are no variants like `aarch64-linux-gnu-clang` and there is no need to check for `-clang` variants.

…oli-obk Add log-backtrace option to show backtraces along with logging according to rust-lang#90698, I added a compiler option, `-Zlog-backtrace=filter`, where `filter` is a module name, to show backtraces for logging without rebuilding. resolve rust-lang#90698

…S_ENTAILMENT, r=lcnr Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow rust-lang#105575 (comment) > and then later in the same cycle increase the lint to `deny` and change it to `FutureCompatReportNow` in this nightly cycle. r? ```@lcnr``` when they're back from holiday 😄

…rochenkov Fix linker detection for linker (drivers) with a version postfix (e.g. clang-12 instead of clang) Linker (drivers) such as clang / gcc or lld often have a version postfix matching the regex "-\d+$". Previously, linker detection did not account for the possible version postfix and the fallback value was used, which can cause linker errors due to wrong arguments. Also remove the check for `-clang`, since there are no architecture specific variants of clang (to my knowledge). Fixes rust-lang#106454

…rrors When suggesting writing a fully qualified path probe for appropriate types Address the more common part of rust-lang#46585.

…est-this, r=estebank Provide help on closures capturing self causing borrow checker errors Fixes rust-lang#105761 r? ````@estebank````

…eholk Warn when using panic-strategy abort for proc-macro crates See rust-lang#82320, this simply warns for now as that seems like the best step that can be immediately taken (opposed to straight up rejecting or ignoring)

…anieu Fix `mpsc::SyncSender` spinning behavior Resolves rust-lang#106668.

…compiler-errors Normalize test output more thoroughly This prevents differences in local environments, which may (for example) end up with a longer backtrace with more digits in the backtrace prefix, as happened to me. While we're at it, clean more of the output up, including the exact location of the error in the compiler. cc rust-lang#106521 which introduced this test

…bjorn3 riscv: Fix ELF header flags The previous version added both `EF_RISCV_FLOAT_ABI_DOUBLE` and `EF_RISCV_RVC` if the "D" extension was enabled on riscv64 targets. riscv32 targets were not accounted for. This patch changes this so that: - Only add `EF_RISCV_RVC` if the "C" extension is enabled - Add `EF_RISCV_FLOAT_ABI_SINGLE` if the "F" extension is enabled and the "D" extension is not - Add these ELF flags for riscv32 as well Fixes rust-lang#104284 r? rust-lang/risc-v

…omez,petrochenkov Remove redundant session field There was already a session available in the resolver, so we access that session.

matthiaskrgr · 2023-01-13T18:17:02Z

@bors r+ rollup=never p=10

bors · 2023-01-13T18:17:04Z

📌 Commit f709382 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-01-13T21:25:54Z

⌛ Testing commit f709382 with merge a11eb4f...

bors · 2023-01-14T00:20:30Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a11eb4f to master...

rust-timer · 2023-01-14T00:23:21Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#106813	434d96399946a7cd08a2c9ab37f906d3eeab3a3b
#106797	eb547c1518b3ea1ab282bbb07485bdeea60f9055
#106793	849ea7d1c036c35a7bc63cb3d11834d5d7ea25d5
#106701	4955a27fa256bf608bfec7d3e644763da313ccb8
#106678	2bbe725418397122668d5ea5440bfd6190257725
#106641	38533c434f2b5a751a5d9d94f01a467dad461220
#106585	8f80c531904e7abd803cb7fb93584775e02ce904
#106489	b777e675623c49fb6304d4ebbd5b75557e82693a
#106465	3f8d419a820174e5203f4019f6cc627f70ac7f2b
#104645	36326c6515062fff1fdf23eec4f8ba383a9763f4

previous master: 0b90256ada

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-14T02:19:58Z

Finished benchmarking commit (a11eb4f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.9%]	4
Regressions ❌ (secondary)	0.5%	[0.3%, 0.8%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.8%, 0.9%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.2%, 2.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[2.2%, 2.6%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

pnkfelix · 2023-01-18T17:37:46Z

the sole primary impacted benchmarks are variants of helloworld-check.

Looking at the graph, I'm categorizing this as noise.

@rustbot label: +perf-regression-triaged

ibraheemdev and others added 26 commits January 10, 2023 21:39

fix SyncSender spinning behavior

2538c0c

add SyncSender::send_timeout test

f8276c9

Add log-backtrace option to show backtraces along with logging

4e2a356

When suggesting writing a fully qualified path probe for appropriate …

12ddf77

…types Fix rust-lang#46585.

review comments

147c9bf

review comments: account for generics

c6f322b

rework and document backoff behavior of sync::mpsc

8917e99

Provide help on closures capturing self causing borrow checker errors

c825459

take care when there is no args in method call

eafbca9

Bump IMPLIED_BOUNDS_ENTAILMENT to Deny + ReportNow

5457140

Add logic to make IMPLIED_BOUNDS_ENTAILMENT easier to understand

eaa7cc8

Warn when using panic-strategy abort for proc-macro crates

549ece7

Remove redundant session field

4aca7be

Rollup merge of rust-lang#106585 - estebank:issue-46585, r=compiler-e…

c6e3a47

…rrors When suggesting writing a fully qualified path probe for appropriate types Address the more common part of rust-lang#46585.

Rollup merge of rust-lang#106641 - chenyukang:yukang/fix-105761-seggu…

57b371a

…est-this, r=estebank Provide help on closures capturing self causing borrow checker errors Fixes rust-lang#105761 r? ````@estebank````

Rollup merge of rust-lang#106701 - ibraheemdev:sync-sender-spin, r=Am…

720137b

…anieu Fix `mpsc::SyncSender` spinning behavior Resolves rust-lang#106668.

Rollup merge of rust-lang#106813 - oli-obk:sess_cleanup, r=GuillaumeG…

f709382

…omez,petrochenkov Remove redundant session field There was already a session available in the resolver, so we access that session.

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 13, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2023

bors merged commit a11eb4f into rust-lang:master Jan 14, 2023

rustbot added this to the 1.68.0 milestone Jan 14, 2023

bors mentioned this pull request Jan 14, 2023

Teach rustc to write the ICE backtrace and query stack to disk #106691

Closed

rustbot added the perf-regression Performance regression. label Jan 14, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jan 18, 2023

clubby789 mentioned this pull request Jan 19, 2023

[ICE]: index out of bounds: the len is 0 but the index is 0 snapshot_vec.rs #107087

Closed

4 tasks

matthiaskrgr deleted the rollup-46bi4pi branch March 16, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #106822

Rollup of 10 pull requests #106822

matthiaskrgr commented Jan 13, 2023

matthiaskrgr commented Jan 13, 2023

bors commented Jan 13, 2023

bors commented Jan 13, 2023

bors commented Jan 14, 2023

rust-timer commented Jan 14, 2023

rust-timer commented Jan 14, 2023

pnkfelix commented Jan 18, 2023 •

edited

Loading

Rollup of 10 pull requests #106822

Rollup of 10 pull requests #106822

Conversation

matthiaskrgr commented Jan 13, 2023

matthiaskrgr commented Jan 13, 2023

bors commented Jan 13, 2023

bors commented Jan 13, 2023

bors commented Jan 14, 2023

rust-timer commented Jan 14, 2023

rust-timer commented Jan 14, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

pnkfelix commented Jan 18, 2023 • edited Loading

pnkfelix commented Jan 18, 2023 •

edited

Loading