Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add raw identifier for keyword in suggestion #106928

Merged
merged 1 commit into from
Jan 20, 2023
Merged

add raw identifier for keyword in suggestion #106928

merged 1 commit into from
Jan 20, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jan 16, 2023

fix #106841

@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2023
@bvanjoi bvanjoi force-pushed the print-keyword-raw-identifier branch from 46a7e44 to 97ae79a Compare January 19, 2023 16:37
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2023

📌 Commit 97ae79a has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 20, 2023
@matthiaskrgr
Rollup merge of rust-lang#106928 - bvanjoi:print-keyword-raw-identifi…
ee2d361 
…er, r=petrochenkov

add raw identifier for keyword in suggestion

fix rust-lang#106841
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2023
@bors
Auto merge of rust-lang#107106 - matthiaskrgr:rollup-g7r1ep0, r=matth…
a6269da 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106699 ([drop tracking] Visit break expressions )
 - rust-lang#106738 (Fix known-bug annotations)
 - rust-lang#106891 (Tweak "borrow closure argument" suggestion)
 - rust-lang#106928 (add raw identifier for keyword in suggestion)
 - rust-lang#107065 (Clippy: Make sure to include in beta: Move `unchecked_duration_subtraction` to pedantic)
 - rust-lang#107068 (autoderive Subdiagnostic for AddtoExternBlockSuggestion)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da7a0c0 into rust-lang:master Jan 20, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 20, 2023
@bvanjoi bvanjoi deleted the print-keyword-raw-identifier branch April 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

diagnostics: rust forgets needed raw identifier in item paths in suggestion
4 participants
@bvanjoi @rustbot @petrochenkov @bors