Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CopyProp #107449

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Enable CopyProp #107449

merged 4 commits into from
Feb 16, 2023

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Jan 29, 2023

r? @tmiasko

@rustbot label +A-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 29, 2023
@saethlin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 29, 2023
@bors
Copy link
Contributor

bors commented Jan 29, 2023

⌛ Trying commit 40bac025b0c5bf2b58dc2c9296712fdb51384248 with merge 17d10909b1d3bc986c8b9d076a502a271005d0ca...

@rustbot rustbot added the A-mir-opt Area: MIR optimizations label Jan 29, 2023
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jan 29, 2023

☀️ Try build successful - checks-actions
Build commit: 17d10909b1d3bc986c8b9d076a502a271005d0ca (17d10909b1d3bc986c8b9d076a502a271005d0ca)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (17d10909b1d3bc986c8b9d076a502a271005d0ca): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.3%, 0.6%] 19
Regressions ❌
(secondary)
1.3% [0.3%, 2.6%] 25
Improvements ✅
(primary)
-1.4% [-3.4%, -0.2%] 101
Improvements ✅
(secondary)
-1.5% [-5.0%, -0.2%] 42
All ❌✅ (primary) -1.1% [-3.4%, 0.6%] 120

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
7.5% [7.5%, 7.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.3% [-18.5%, -0.5%] 83
Improvements ✅
(secondary)
-2.2% [-4.3%, -1.0%] 38
All ❌✅ (primary) -2.2% [-18.5%, 7.5%] 84

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
-2.0% [-3.8%, -1.1%] 39
Improvements ✅
(secondary)
-2.6% [-5.2%, -0.9%] 35
All ❌✅ (primary) -2.0% [-3.8%, -1.1%] 39

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 29, 2023
@saethlin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 30, 2023
@bors
Copy link
Contributor

bors commented Jan 30, 2023

⌛ Trying commit a4761784c10bc2ae74708eb7c1fcdc3640c8d78e with merge e88d7b813d61bb88e98a746089b1fd25b7ff7b68...

@bors
Copy link
Contributor

bors commented Jan 30, 2023

☀️ Try build successful - checks-actions
Build commit: e88d7b813d61bb88e98a746089b1fd25b7ff7b68 (e88d7b813d61bb88e98a746089b1fd25b7ff7b68)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e88d7b813d61bb88e98a746089b1fd25b7ff7b68): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.3%, 1.2%] 30
Regressions ❌
(secondary)
1.6% [0.2%, 6.2%] 39
Improvements ✅
(primary)
-0.9% [-3.7%, -0.3%] 85
Improvements ✅
(secondary)
-1.3% [-3.4%, -0.2%] 26
All ❌✅ (primary) -0.5% [-3.7%, 1.2%] 115

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [2.5%, 4.7%] 5
Regressions ❌
(secondary)
5.1% [4.6%, 5.5%] 2
Improvements ✅
(primary)
-2.0% [-12.5%, -0.4%] 39
Improvements ✅
(secondary)
-2.5% [-3.9%, -1.5%] 13
All ❌✅ (primary) -1.4% [-12.5%, 4.7%] 44

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-2.0% [-3.2%, -1.2%] 7
Improvements ✅
(secondary)
-2.5% [-4.3%, -0.9%] 15
All ❌✅ (primary) -2.0% [-3.2%, -1.2%] 7

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 30, 2023
@saethlin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 30, 2023
@bors
Copy link
Contributor

bors commented Jan 30, 2023

⌛ Trying commit 428c49cfa461a921fb694086c6d93667b380205d with merge cb93b77c3bf8fa32a9694884494997daafede68e...

@bors
Copy link
Contributor

bors commented Feb 15, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Feb 15, 2023

@bors retry building LLVM failed: could not create temporary file whilst writing archive: no more archived files

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2023
@bors
Copy link
Contributor

bors commented Feb 16, 2023

⌛ Testing commit 37a875c with merge 639377e...

@bors
Copy link
Contributor

bors commented Feb 16, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 639377e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2023
@bors bors merged commit 639377e into rust-lang:master Feb 16, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (639377e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.4%] 2
Regressions ❌
(secondary)
1.2% [0.1%, 2.7%] 5
Improvements ✅
(primary)
-1.4% [-4.4%, -0.3%] 151
Improvements ✅
(secondary)
-1.7% [-5.5%, -0.3%] 57
All ❌✅ (primary) -1.4% [-4.4%, 0.4%] 153

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
5.0% [1.4%, 9.4%] 6
Regressions ❌
(secondary)
3.1% [3.0%, 3.2%] 2
Improvements ✅
(primary)
-1.9% [-4.8%, -0.5%] 60
Improvements ✅
(secondary)
-2.4% [-2.9%, -1.9%] 5
All ❌✅ (primary) -1.3% [-4.8%, 9.4%] 66

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
-1.8% [-2.7%, -0.9%] 36
Improvements ✅
(secondary)
-2.8% [-4.4%, -0.8%] 32
All ❌✅ (primary) -1.8% [-2.7%, -0.9%] 36

@nnethercote
Copy link
Contributor

The improvements here massively outweigh the tiny number of regressions.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 16, 2023
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
curl: (22) The requested URL returned error: 404

error: failed to download llvm from ci

    help: old builds get deleted after a certain time
    help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:

    [llvm]
    download-ci-llvm = false
Build completed unsuccessfully in 0:00:00

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[2535/3025] Linking CXX static library lib\libLLVMDlltoolDriver.a
[2536/3025] Linking CXX static library lib\libLLVMObjCopy.a
[2537/3025] Linking CXX static library lib\libLLVMLibDriver.a
FAILED: lib/libLLVMLibDriver.a 
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E rm -f lib\libLLVMLibDriver.a && D:\a\rust\rust\mingw64\bin\ar.exe qc lib\libLLVMLibDriver.a  lib/ToolDrivers/llvm-lib/CMakeFiles/LLVMLibDriver.dir/LibDriver.cpp.obj && D:\a\rust\rust\mingw64\bin\ranlib.exe lib\libLLVMLibDriver.a && cd ."
D:\a\rust\rust\mingw64\bin\ranlib.exe: could not create temporary file whilst writing archive: no more archived files
[2538/3025] Linking CXX static library lib\libLLVMJITLink.a
[2539/3025] Linking CXX static library lib\libLLVMRuntimeDyld.a
[2540/3025] Linking CXX static library lib\libLLVMDebugInfoGSYM.a
[2541/3025] Linking CXX static library lib\libLLVMDebugInfoPDB.a
[2541/3025] Linking CXX static library lib\libLLVMDebugInfoPDB.a
[2542/3025] Linking CXX static library lib\libLLVMObjectYAML.a
[2543/3025] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordPrinter.cpp.obj
[2544/3025] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/Profile.cpp.obj
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cmake-0.1.48\src\lib.rs:975:5
 finished in 242.088 seconds
Build completed unsuccessfully in 0:07:17

@saethlin saethlin deleted the enable-copyprop branch March 15, 2023 00:33
tmiasko added a commit to tmiasko/rust that referenced this pull request Oct 5, 2023
Generalizes the small dominators approach from rust-lang#107449.
tmiasko added a commit to tmiasko/rust that referenced this pull request Oct 5, 2023
Generalizes the small dominators approach from rust-lang#107449.
tmiasko added a commit to tmiasko/rust that referenced this pull request Oct 5, 2023
Generalizes the small dominators approach from rust-lang#107449.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mir-opt Area: MIR optimizations merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants