Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some UI tests into subdirectories #109873

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 2, 2023

No description provided.

to avoid going over the existing limit now that the ui-fulldeps tests have
been moved to ui.
@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2023
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 3, 2023

📌 Commit 01b75e2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109526 (LIBPATH is used as dylib's path environment variable on AIX)
 - rust-lang#109642 (check for missing codegen backeng config)
 - rust-lang#109722 (Implement read_buf for RustHermit)
 - rust-lang#109856 (fix(middle): emit error rather than delay bug when reaching limit)
 - rust-lang#109868 (Improve PR job names in Github Actions preview)
 - rust-lang#109871 (Include invocation start times)
 - rust-lang#109873 (Move some UI tests into subdirectories)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 22df710 into rust-lang:master Apr 3, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 3, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2023
Move most ui-fulldeps tests to ui/

Same rationale as rust-lang#109770, they don't actually need a stage 2 build.

This increases the limit for the UI directory because otherwise it was annoying to be constantly moving files into subdirectories when I fixed a test; rust-lang#109873 makes up for it.

cc rust-lang#109770, rust-lang#109874
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Apr 14, 2023
Move most ui-fulldeps tests to ui/

Same rationale as rust-lang/rust#109770, they don't actually need a stage 2 build.

This increases the limit for the UI directory because otherwise it was annoying to be constantly moving files into subdirectories when I fixed a test; rust-lang/rust#109873 makes up for it.

cc rust-lang/rust#109770, rust-lang/rust#109874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants