fix: skip implied bounds if unconstrained lifetime exists #110272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
|
||
| // We must avoid processing constrained lifetime variables in implied | ||
| // bounds. See #110161 for context. | ||
| if ty.needs_infer() { |
There was a problem hiding this comment.
I would keep the assertion around for has_non_lifetime_infer and only delay a span bug if we have infer lifetimes.
There was a problem hiding this comment.
I guess type vars has the same problem. For a test case, we can probably replace &'lt () by (X,) in the ui test. I'm not sure though.
There was a problem hiding this comment.
fwiw (and I'm completely inexperienced), I think we are good here, there aren't unconstrained type variables in the same way?
aliemjay
reviewed
Apr 14, 2023
|
@aliemjay Implemented review suggestions. |
aliemjay
reviewed
Apr 15, 2023
|
@bors r+ rollup=always |
bors
added
S-waiting-on-bors
aliemjay
added a commit
to aliemjay/rust
that referenced
this pull request
Apr 15, 2023
…unds, r=aliemjay fix: skip implied bounds if unconstrained lifetime exists Fixes rust-lang#110161 r? `@aliemjay`
aliemjay
added a commit
to aliemjay/rust
that referenced
this pull request
Apr 15, 2023
…unds, r=aliemjay fix: skip implied bounds if unconstrained lifetime exists Fixes rust-lang#110161 r? ``@aliemjay``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 15, 2023
…unds, r=aliemjay fix: skip implied bounds if unconstrained lifetime exists Fixes rust-lang#110161 r? ```@aliemjay```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#110033 (Add 1.69.0 release notes) - rust-lang#110272 (fix: skip implied bounds if unconstrained lifetime exists) - rust-lang#110307 (Allow everyone to set the beta-nominated label) - rust-lang#110347 (Add intra-doc links to size_of_* functions) - rust-lang#110350 (Add a UI test for rust-lang#79605) - rust-lang#110356 (Fix `x test rust-installer` when `cargo` is set to a relative path) - rust-lang#110364 (remove redundant clones) - rust-lang#110366 (fix some clippy::complexity) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110161
r? @aliemjay