Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc --help add --cfg SPEC declaration. #110594

Merged
merged 1 commit into from
Apr 26, 2023
Merged

rustc --help add --cfg SPEC declaration. #110594

merged 1 commit into from
Apr 26, 2023

Conversation

infdahai
Copy link
Contributor

@infdahai infdahai commented Apr 20, 2023 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Apr 20, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2023
@jyn514 jyn514 changed the title rust --help add --cfg SPEC declaration. rustc --help add --cfg SPEC declaration. Apr 20, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 20, 2023

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned oli-obk Apr 20, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

I think this was already correct in 8d5a742: NAME[=\"VALUE\"]. Is there a reason you changed it to NAME=\"VALUE\"? I'd prefer to show that both forms are valid.

@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

Also, please squash the commits into one so we don't end up with a binary in the git history.

@infdahai
add cfg SPEC declaration.
27c0d92 
use name[=value] syntax.

Signed-off-by: clundro <[email protected]>
@infdahai
Copy link
Contributor Author

@jyn514 It's done. I misunderstood it before

@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 26, 2023

📌 Commit 27c0d92 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@jyn514 jyn514 mentioned this pull request Apr 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
@bors
Auto merge of rust-lang#110839 - jyn514:rollup-uikilwm, r=jyn514
ae3ab14 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#108416 (black_box doc corrections for clarification - Issue rust-lang#107957)
 - rust-lang#109379 (Replace `yes` command by `while-echo` in test `tests/ui/process/process-sigpipe.rs`)
 - rust-lang#110266 (Update documentation wording on path 'try_exists' functions)
 - rust-lang#110329 (Improve tests for rust-lang#110138)
 - rust-lang#110418 (Spelling rustdoc)
 - rust-lang#110587 (Fix `std` compilation error for wasi+atomics)
 - rust-lang#110594 (`rustc --help` add `--cfg` SPEC declaration.)
 - rust-lang#110792 (Use the standard macOS CI runner)
 - rust-lang#110817 (Add regression tests for const-generic inherent associated types)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62b5bea into rust-lang:master Apr 26, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 26, 2023
@infdahai infdahai deleted the cfg_chore branch April 26, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

rustc --help should define SPEC
6 participants
@infdahai @rustbot @oli-obk @rust-log-analyzer @jyn514 @bors