Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't infer fn return type to return itself #110700

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Don't infer fn return type to return itself #110700

merged 1 commit into from
Apr 24, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #110687

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 22, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 22, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 22, 2023

📌 Commit c8874e2 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2023
@compiler-errors compiler-errors mentioned this pull request Apr 22, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 22, 2023
@compiler-errors
Rollup merge of rust-lang#110700 - compiler-errors:fn-ret-fn, r=oli-obk
eb33b1d 
Don't infer fn return type to return itself

Fixes rust-lang#110687
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2023
@bors
Auto merge of rust-lang#110736 - matthiaskrgr:rollup-gorv8zp, r=matth…
8991768 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110661 (rustdoc: clean up settings.css and settings.js)
 - rust-lang#110663 (Add note about change in bootstrap defaults)
 - rust-lang#110664 (stop `x fmt` formatting untracked directories)
 - rust-lang#110668 (Fix printing native CPU on cross-compiled compiler.)
 - rust-lang#110689 (Fix grammar in core::hint::unreachable_unchecked() docs)
 - rust-lang#110700 (Don't infer fn return type to return itself)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 12858d9 into rust-lang:master Apr 24, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 24, 2023
@compiler-errors compiler-errors deleted the fn-ret-fn branch August 11, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

ICE: stack overflow in diagnostics with 2 identical broken fns
4 participants
@compiler-errors @rustbot @oli-obk @bors