Validate resolution for SelfCtor too. #111020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
petrochenkov
reviewed
May 3, 2023
| Res::Def(DefKind::TyParam, _) | ||
| | Res::SelfTyParam { .. } | ||
| | Res::SelfTyAlias { .. } | ||
| | Res::SelfCtor(_) => { |
There was a problem hiding this comment.
This is a strange place to report this error because neither SelfTyAlias nor SelfCtor have anything to do with type parameters, but seems fine in the meantime.
petrochenkov
added
S-waiting-on-author
cjgillot
force-pushed
the
validate-self-ctor
branch
from
42b0f88
to
8345340
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110859 (Explicitly reject negative and reservation drop impls) - rust-lang#111020 (Validate resolution for SelfCtor too.) - rust-lang#111024 (Use the full Fingerprint when stringifying Svh) - rust-lang#111027 (Remove `allow(rustc::potential_query_instability)` for `builtin_macros`) - rust-lang#111039 (Encode def span for foreign return-position `impl Trait` in trait) - rust-lang#111070 (Don't suffix `RibKind` variants) - rust-lang#111094 (Add needs-unwind annotations to tests that need stack unwinding) - rust-lang#111103 (correctly recurse when expanding anon consts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
gnoliyil
pushed a commit
to gnoliyil/fuchsia
that referenced
this pull request
Jan 27, 2024
Newest rust toolchain now errors out on the usage of generic parameter from outer function. Fix is to refer directly to type instead of Self. https: //github.com/rust-lang/rust/pull/111020 Change-Id: Ibbf67afe8ad43d061060f96d538cbbbe505c2901 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/852250 Commit-Queue: Andrew Pollack <[email protected]> Reviewed-by: Ben Keller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89868
r? @petrochenkov