CFI: Fix SIGILL reached via trait objects #111375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
CC @maurer |
|
r? @bjorn3 |
This comment has been minimized.
This comment has been minimized.
rcvalle
force-pushed
the
rust-cfi-fix-106547
branch
from
bb90480
to
030098a
Compare
This comment has been minimized.
This comment has been minimized.
rcvalle
force-pushed
the
rust-cfi-fix-106547
branch
from
030098a
to
f6d078b
Compare
This comment has been minimized.
This comment has been minimized.
rcvalle
force-pushed
the
rust-cfi-fix-106547
branch
from
f6d078b
to
7740b8d
Compare
This comment has been minimized.
This comment has been minimized.
rcvalle
force-pushed
the
rust-cfi-fix-106547
branch
from
7740b8d
to
7e0b6b8
Compare
rcvalle
force-pushed
the
rust-cfi-fix-106547
branch
from
7e0b6b8
to
a344391
Compare
This comment has been minimized.
This comment has been minimized.
rcvalle
force-pushed
the
rust-cfi-fix-106547
branch
from
a344391
to
7fc555c
Compare
This comment has been minimized.
This comment has been minimized.
Fix rust-lang#106547 by transforming the concrete self into a reference to a trait object before emitting type metadata identifiers for trait methods.
rcvalle
force-pushed
the
rust-cfi-fix-106547
branch
from
7fc555c
to
7c7b22e
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#106038 (use implied bounds when checking opaque types) - rust-lang#111366 (Make `NonUseContext::AscribeUserTy` carry `ty::Variance`) - rust-lang#111375 (CFI: Fix SIGILL reached via trait objects) - rust-lang#111439 (Fix backtrace normalization in ice-bug-report-url.rs) - rust-lang#111444 (Only warn single-use lifetime when the binders match.) - rust-lang#111459 (Update browser-ui-test version to 0.16.0) - rust-lang#111460 (Improve suggestion for `self: Box<self>`) Failed merges: - rust-lang#110454 (Require impl Trait in associated types to appear in method signatures) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #106547 by transforming the concrete self into a reference to a trait object before emitting type metadata identifiers for trait methods.