-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use error term in projection if missing associated item in new solver #111488
Conversation
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
.const_error_with_guaranteed( | ||
tcx.type_of(goal.predicate.def_id()) | ||
.subst(tcx, goal.predicate.projection_ty.substs), | ||
guar, | ||
) | ||
.into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realized that the naming for ty_error
and const_error
is inconsistent afaict 🤔 we should unify these.
Probably makes sense to open a github issue for that unless you have some time @compiler-errors .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was done in #111570 which probably means this PR needs to be rebased
@bors r+ rollup |
📌 Commit a5ce6e843839f3a12e7e123c8ae142d62090da1f has been approved by It is now in the queue for this repository. |
@bors r- probably needs a rebase |
lol yes boxy is right, i should rebase this |
a5ce6e8
to
8921391
Compare
@bors r=lcnr |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107680 (Hide repr attribute from doc of types without guaranteed repr) - rust-lang#111488 (Use error term in projection if missing associated item in new solver) - rust-lang#111533 (Handle error body in generator layout) - rust-lang#111573 (Erase `ReError` properly) - rust-lang#111592 (Change Vec examples to not assert exact capacity except where it is guaranteed) - rust-lang#111610 (fix(diagnostic): wrap parens for ref impl trait param) - rust-lang#111642 ([rustdoc] Only keep impl blocks from bodies) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
We were previously delaying a bug but not bailing, leading to an ICE in the
tcx.type_of(assoc_def.item.def_id)
call below.