Use error term in projection if missing associated item in new solver #111488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
May 12, 2023
lcnr
reviewed
May 16, 2023
Comment on lines
133
to
138
| .const_error_with_guaranteed( | ||
| tcx.type_of(goal.predicate.def_id()) | ||
| .subst(tcx, goal.predicate.projection_ty.substs), | ||
| guar, | ||
| ) | ||
| .into(), |
There was a problem hiding this comment.
realized that the naming for ty_error and const_error is inconsistent afaict 🤔 we should unify these.
Probably makes sense to open a github issue for that unless you have some time @compiler-errors .
There was a problem hiding this comment.
this was done in #111570 which probably means this PR needs to be rebased
|
@bors r+ rollup |
|
📌 Commit a5ce6e843839f3a12e7e123c8ae142d62090da1f has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
@bors r- probably needs a rebase |
bors
added
S-waiting-on-author
|
lol yes boxy is right, i should rebase this |
rust-cloud-vms
bot
force-pushed
the
error-term
branch
from
a5ce6e8
to
8921391
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#107680 (Hide repr attribute from doc of types without guaranteed repr) - rust-lang#111488 (Use error term in projection if missing associated item in new solver) - rust-lang#111533 (Handle error body in generator layout) - rust-lang#111573 (Erase `ReError` properly) - rust-lang#111592 (Change Vec examples to not assert exact capacity except where it is guaranteed) - rust-lang#111610 (fix(diagnostic): wrap parens for ref impl trait param) - rust-lang#111642 ([rustdoc] Only keep impl blocks from bodies) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously delaying a bug but not bailing, leading to an ICE in the
tcx.type_of(assoc_def.item.def_id)call below.