Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tests for pretty-printing inherent projections #111887

Merged
merged 1 commit into from
May 24, 2023

Conversation

fmease
Copy link
Member

@fmease fmease commented May 23, 2023

Tests for #111486.
Fixes #111879.

r? @matthiaskrgr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 23, 2023
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 24, 2023

📌 Commit 4a63b07 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2023
LL | fn main(_: for<'a> fn(Foo<fn(&'a ())>::Assoc)) {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ incorrect number of function parameters
|
= note: expected fn pointer `fn()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side-note, it would be nice if we got this to say "expected signature"... but the problem is that require_same_types takes (fn ptr) types instead of poly fn sigs. Whatever, I guess.

bors added a commit to rust-lang-ci/rust that referenced this pull request May 24, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#111861 (Don't ICE on return-type notation when promoting trait preds to associated type bounds)
 - rust-lang#111864 (Always require closure parameters to be `Sized`)
 - rust-lang#111870 (Rename `traits_in_crate` query to `traits`)
 - rust-lang#111880 (Don't ICE when computing PointerLike trait when region vars are in param-env)
 - rust-lang#111887 (Add regression tests for pretty-printing inherent projections)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d49d347 into rust-lang:master May 24, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 24, 2023
@fmease fmease deleted the inh-proj-pp-tests branch May 24, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: inherent_associated_types: Unexpected parameter Type(..) ... when substituting in region..
6 participants