Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust.md : update crate attributes. #11190

Merged
merged 1 commit into from
Dec 30, 2013
Merged

rust.md : update crate attributes. #11190

merged 1 commit into from
Dec 30, 2013

Conversation

eliovir
Copy link
Contributor

@eliovir eliovir commented Dec 29, 2013

[ author = "Jane Doe" ]; raises "warning: unknown crate attribute"

replace pkgid by crate_id
add comment

#[ author = "Jane Doe" ]; raises "warning: unknown crate attribute"
@emberian
Copy link
Member

Will need to be rebased on top of #11182

@eliovir
Copy link
Contributor Author

eliovir commented Dec 29, 2013

Hi, I've just done a git rebase upstream/master and git push -f origin master. I'm not used to use git commands. I hope things are right.

@eliovir eliovir closed this Dec 29, 2013
@eliovir eliovir reopened this Dec 29, 2013
@adrientetar
Copy link
Contributor

@eliovir You should wait until it's merged before rebasing. As you can see it has no effects right now since #11182 is not upstream.

@adrientetar
Copy link
Contributor

bors added a commit that referenced this pull request Dec 30, 2013
#[ author = "Jane Doe" ]; raises "warning: unknown crate attribute"
replace `pkgid` by `crate_id`
add `comment`
@bors bors closed this Dec 30, 2013
@bors bors merged commit 4660659 into rust-lang:master Dec 30, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 11, 2023
…ice, r=llogiq

redundant_type_annotations: only pass certain def kinds to type_of

Fixes rust-lang#11190
Fixes rust-lang#113516

Also adds an `is_lint_allowed` check to skip the lint when it's not needed

changelog: none
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 17, 2023
…ice, r=llogiq

redundant_type_annotations: only pass certain def kinds to type_of

Fixes rust-lang#11190
Fixes rust-lang#113516

Also adds an `is_lint_allowed` check to skip the lint when it's not needed

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants