Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove TyCtxt::has_error_field helper method #112340

Merged
merged 1 commit into from
Jun 7, 2023
Merged

remove TyCtxt::has_error_field helper method #112340

merged 1 commit into from
Jun 7, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jun 6, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 6, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2023
@compiler-errors
Copy link
Member

noting for any PR onlookers that this PR also changes it to check references_error, which is why the diagnostics change a bit. should be harmless.

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 6, 2023

📌 Commit 01aaad3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 6, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2023
@bors
Auto merge of rust-lang#112361 - matthiaskrgr:rollup-39zxrw1, r=matth…
afab366 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#111250 (Add Terminator conversion from MIR to SMIR, part #2)
 - rust-lang#112310 (Add new Tier-3 targets: `loongarch64-unknown-none*`)
 - rust-lang#112334 (Add myself to highfive rotation)
 - rust-lang#112340 (remove `TyCtxt::has_error_field` helper method)
 - rust-lang#112343 (Prevent emitting `missing_docs` for `pub extern crate`)
 - rust-lang#112350 (Avoid duplicate type sanitization of local decls in borrowck)
 - rust-lang#112356 (Fix comment for `get_region_var_origins`)
 - rust-lang#112358 (Remove default visitor impl in region constraint generation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e937fa4 into rust-lang:master Jun 7, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 7, 2023
@lcnr lcnr deleted the tyctxt-cleanup branch June 7, 2023 13:43
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @rustbot @compiler-errors @bors @wesleywiser