Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont compute opt_suggest_box_span span for TAIT #112513

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #112434

Also a couple more commits on top, pruning some dead code and fixing another weird suggestion encountered in the above issue.

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2023
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 11, 2023

📌 Commit d804402 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#112487 (Update documentation for `tools` defaults)
 - rust-lang#112513 (Dont compute `opt_suggest_box_span` span for TAIT)
 - rust-lang#112528 (bootstrap: Don't override `debuginfo-level = 1` to mean `line-tables-only`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d9ae718 into rust-lang:master Jun 11, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 11, 2023
@compiler-errors compiler-errors deleted the dont-compute-box-span-for-tait branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug ice: suggestion must not have overlapping parts , suggests -> Box<dyn>
4 participants