Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liberate bound vars properly when suggesting missing async-fn-in-trait #112868

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Liberate bound vars properly when suggesting missing async-fn-in-trait #112868

merged 1 commit into from
Jun 21, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #112848

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2023
WaffleLapkin
WaffleLapkin reviewed Jun 21, 2023
View reviewed changes
compiler/rustc_hir_analysis/src/check/mod.rs Outdated
@@ -477,7 +477,10 @@ fn suggestion_signature<'tcx>(
// regions just fine, showing `fn(&MyType)`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this comment? it still mentions the removed .skip_binder().

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, done

@WaffleLapkin
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 21, 2023

📌 Commit 7563909 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2023
@bors
Auto merge of rust-lang#112900 - GuillaumeGomez:rollup-1blf4io, r=Gui…
065a1f5 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112538 (Removed unnecessary &String -> &str, now that &String implements StableOrd as well)
 - rust-lang#112868 (Liberate bound vars properly when suggesting missing async-fn-in-trait)
 - rust-lang#112892 (resolve: Minor cleanup to `fn resolve_path_with_ribs`)
 - rust-lang#112894 (Fix union fields display)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5ed75a9 into rust-lang:master Jun 21, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jun 21, 2023
@compiler-errors compiler-errors deleted the liberate-afit-sugg branch August 11, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

ice: expected async fn to have impl Future output, but it returns impl Future<Output = i32>
4 participants
@compiler-errors @rustbot @WaffleLapkin @bors