Account for late-bound vars from parent arg-position impl trait #113071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
fmease
requested changes
Jun 26, 2023
tests/ui/traits/non_lifetime_binders/nested-apit-mentioning-outer-bound-var.stderr
Outdated
Show resolved
Hide resolved
fmease
requested changes
Jun 26, 2023
rust-cloud-vms
bot
force-pushed
the
no-parent-non-lifetime-args-in-apit
branch
from
2a74d7c
to
724f3ff
Compare
fmease
approved these changes
Jun 29, 2023
eholk
reviewed
Jun 29, 2023
| type Assoc; | ||
| } | ||
|
|
||
| fn uwu(_: impl for<T> Trait<(), Assoc = impl Trait<T>>) {} |
There was a problem hiding this comment.
Huh, I didn't even know for<T> was a thing!
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 30, 2023
…time-args-in-apit, r=eholk Account for late-bound vars from parent arg-position impl trait We should be reporting an error like we do for late-bound args coming from a parent APIT. Fixes rust-lang#113016
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 30, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#107624 (Stabilize `const_cstr_methods`) - rust-lang#111403 (suggest `slice::swap` for `mem::swap(&mut x[0], &mut x[1])` borrowck error) - rust-lang#113071 (Account for late-bound vars from parent arg-position impl trait) - rust-lang#113165 (Encode item bounds for `DefKind::ImplTraitPlaceholder`) - rust-lang#113171 (Properly implement variances_of for RPITIT GAT) - rust-lang#113177 (Use structured suggestion when telling user about `for<'a>`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be reporting an error like we do for late-bound args coming from a parent APIT.
Fixes #113016