Don't install default projection bound for return-position impl Trait in trait methods with no body
#113741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
changed the title
impl Trait in trait methods with no bodyimpl Trait in trait methods with no body
|
Makes a lot of sense, r=me after rebasing |
rust-cloud-vms
bot
force-pushed
the
rpitit-projects-to-missing-opaque
branch
from
e8bb06b
to
0773dc0
Compare
|
This is actually blocked on #113704, which I will clean up and write a better explanation for probably on Monday. |
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
rpitit-projects-to-missing-opaque
branch
from
0773dc0
to
0f0ab89
Compare
|
@bors r=spastorino |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jul 31, 2023
…-missing-opaque, r=spastorino Don't install default projection bound for return-position `impl Trait` in trait methods with no body This ensures that we never try to project to an opaque type in a trait method that has no body to infer its hidden type, which means we never later call `type_of` on that opaque. This is because opaque types try to reveal their hidden type when proving auto traits. I thought about this a lot, and I think this is a fix that's less likely to introduce other strange downstream ICEs than rust-lang#113461. r? `@spastorino`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2023
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#95965 (Stabilize const-weak-new) - rust-lang#109075 (Use `LazyLock` to lazily resolve backtraces) - rust-lang#113741 (Don't install default projection bound for return-position `impl Trait` in trait methods with no body) - rust-lang#114268 (Fix empty_write since rust version attribute) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we never try to project to an opaque type in a trait method that has no body to infer its hidden type, which means we never later call
type_ofon that opaque. This is because opaque types try to reveal their hidden type when proving auto traits.I thought about this a lot, and I think this is a fix that's less likely to introduce other strange downstream ICEs than #113461.
Fixes #113434
r? @spastorino