Normalize lazy type aliases when probing for ADTs #113755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
commented
Jul 16, 2023
| @@ -302,7 +302,9 @@ impl<'a, 'tcx> AstConv<'tcx> for FnCtxt<'a, 'tcx> { | |||
| match ty.kind() { | |||
| ty::Adt(adt_def, _) => Some(*adt_def), | |||
| // FIXME(#104767): Should we handle bound regions here? | |||
| ty::Alias(ty::Projection | ty::Inherent, _) if !ty.has_escaping_bound_vars() => { | |||
| ty::Alias(ty::Projection | ty::Inherent | ty::Weak, _) | |||
| if !ty.has_escaping_bound_vars() => | |||
There was a problem hiding this comment.
Couldn't come up with a snippet containing a weak type alias in expression position that has escaping bound vars.
There was a problem hiding this comment.
Can't have it in path expressions, which is where this would be encountered afaict.
Also, should we only normalize away the layers of lazy type alias? This also has the side effect of an alias that normalizes to a regular projection gets normalized.
Why don't we normalize here to begin with? Does @aliemjay know?
Ideally, this would just pass ty.normalized instead of ty.raw...
|
@bors r+ rollup Yeap, this feature is very incomplete. I'll need to come up with a plan for finishing it. But fuzzing for ices is a great way to find the worst issues |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 16, 2023
…s, r=oli-obk Normalize lazy type aliases when probing for ADTs Fixes rust-lang#113736. r? `@oli-obk`
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jul 16, 2023
…s, r=oli-obk Normalize lazy type aliases when probing for ADTs Fixes rust-lang#113736. r? ``@oli-obk``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#113042 (Add Platform Support documentation for MIPS Release 6 targets) - rust-lang#113539 (fixed typo) - rust-lang#113614 (platform-support.md: It's now verified that NetBSD/riscv64 can self-h…) - rust-lang#113750 (Add missing italicization to `sort_unstable_by_key` complexity ) - rust-lang#113755 (Normalize lazy type aliases when probing for ADTs) - rust-lang#113756 (fix wrong link) - rust-lang#113762 (Fix typo) r? `@ghost` `@rustbot` modify labels: rollup
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113736.
r? @oli-obk