Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use erased self type when autoderefing for trait error suggestion #113985

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

compiler-errors
Copy link
Member

Let's not try to pass something from skip_binder into autoderef.

Fixes #113951

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 23, 2023
@rust-log-analyzer

This comment has been minimized.

@estebank
Copy link
Contributor

r? @estebank
@bors r+

@bors
Copy link
Contributor

bors commented Jul 24, 2023

📌 Commit d1380a1 has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned TaKO8Ki Jul 24, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#113969 (add dynamic for smir)
 - rust-lang#113985 (Use erased self type when autoderefing for trait error suggestion)
 - rust-lang#113987 (Comment stuff in the new solver)
 - rust-lang#113992 (arm-none fixups)
 - rust-lang#113993 (Optimize format usage)
 - rust-lang#113994 (Optimize format usage)
 - rust-lang#114006 (Update sparc-unknown-none-elf platform README)
 - rust-lang#114021 (Add missing documentation for `Session::time`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 15c7234 into rust-lang:master Jul 24, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 24, 2023
@compiler-errors compiler-errors deleted the issue-113951 branch August 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: has escaping bound vars, so it cannot be wrapped in a dummy binder.
6 participants