Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When flushing delayed span bugs, write to the ICE dump file even if it doesn't exist #114128

Merged
merged 1 commit into from
Jul 29, 2023
Merged

When flushing delayed span bugs, write to the ICE dump file even if it doesn't exist #114128

merged 1 commit into from
Jul 29, 2023

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jul 27, 2023 •
edited
Loading

Fix #113881.

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 27, 2023
@estebank estebank mentioned this pull request Jul 27, 2023
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once CI passes

@estebank
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jul 28, 2023

📌 Commit 656213c has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 28, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 28, 2023
@matthiaskrgr
Rollup merge of rust-lang#114128 - estebank:delayed-span-bug-dump, r=…
02359be 
…davidtwco

When flushing delayed span bugs, write to the ICE dump file even if it doesn't exist

Fix rust-lang#113881.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 28, 2023
@bors
Auto merge of rust-lang#114181 - matthiaskrgr:rollup-14m8s7f, r=matth…
ca1f813 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114099 (privacy: no nominal visibility for assoc fns )
 - rust-lang#114128 (When flushing delayed span bugs, write to the ICE dump file even if it doesn't exist)
 - rust-lang#114138 (Adjust spans correctly for fn -> method suggestion)
 - rust-lang#114146 (Skip reporting item name when checking RPITIT GAT's associated type bounds hold)
 - rust-lang#114147 (Insert RPITITs that were shadowed by missing ADTs that resolve to [type error])
 - rust-lang#114155 (Replace a lazy `RefCell<Option<T>>` with `OnceCell<T>`)
 - rust-lang#114164 (Add regression test for `--cap-lints allow` and trait bounds warning)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 02f1e2a into rust-lang:master Jul 29, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 29, 2023
@estebank estebank deleted the delayed-span-bug-dump branch November 9, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

backtrace missing from file
5 participants
@estebank @rustbot @rust-log-analyzer @bors @davidtwco