Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for const async fn #116178

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Add test for const async fn #116178

merged 1 commit into from
Sep 27, 2023

Conversation

Milo123459
Copy link
Contributor

This adds a test for #102796

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2023
@Milo123459 Milo123459 mentioned this pull request Sep 26, 2023
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
cjgillot
cjgillot reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your future contributions, could you avoid adding an issue number in the PR title? We can't click on it... Adding a summary of the referenced PR's title is much more useful.

tests/ui/async-await/const-async/const-async-fn-in-main.rs Outdated Show resolved Hide resolved
@Milo123459 Milo123459 changed the title Add test for #102796 Add test for const async fn Sep 26, 2023
@compiler-errors
Copy link
Member

please squash this into one commit as well

@Milo123459
add test
35f9345 
fix tidy

remove dir
@Milo123459
Copy link
Contributor Author

done - sorry for not.

@wesleywiser
Copy link
Member

Thanks @Milo123459!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 27, 2023

📌 Commit 35f9345 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2023
@bors
Auto merge of rust-lang#116193 - matthiaskrgr:rollup-wpt7m5t, r=matth…
085acd0 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#115934 (Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things)
 - rust-lang#116149 (Anonymize binders for `refining_impl_trait` check)
 - rust-lang#116178 (Add test for `const async fn`)
 - rust-lang#116187 (Add context to `let: Ty = loop { break };`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 243ce35 into rust-lang:master Sep 27, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 27, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2023
@rust-timer
Unrolled build for rust-lang#116178
f8e3947 
Rollup merge of rust-lang#116178 - Milo123459:milo/add-test-for-const-async-function-in-main, r=wesleywiser

Add test for `const async fn`

This adds a test for rust-lang#102796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Milo123459 @rustbot @rust-log-analyzer @compiler-errors @wesleywiser @bors @cjgillot