-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid ICE when Canonicalizer.infcx
is None
#119416
Conversation
ICE: with_negative_coherence: None in compiler/rustc_infer/src/infer/canonical/canonicalizer.rs
(rustbot has picked a reviewer for you, use r? to override) |
@@ -0,0 +1,16 @@ | |||
#![feature(with_negative_coherence)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of this issue doesn't really explain why it's an ICE. Specifically, there's no explanation for why we're encountering an inference variable in the type of a constant inside of a param-env, which is why this ICE occurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right solution, and causes us to totally ignore canonicalization for infer vars when the infcx is not provided. I'm pretty surprised that this even passes at all!
Please make sure to enable debug assertions in your local fork of the compiler, since this debug assertion fails with your modification:
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
Closes #119381