Support ~const in associated functions in trait impls
#119705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Wait, the UI test is not a true reproducer for the linked issue, oops! |
fmease
added
S-waiting-on-author
fmease
added
S-waiting-on-review
compiler-errors
approved these changes
Jan 7, 2024
fmease
commented
Jan 7, 2024
|
|
||
| impl const Main for () { | ||
| fn compute<T: ~const Aux>() -> u32 { | ||
| T::generate() |
There was a problem hiding this comment.
Wait, the UI test is not a true reproducer for the linked issue, oops!
Well, it would be a reproducer of the ICE if I replaced the body with 0
Suggested change
| T::generate() | |
| 0 |
but then the test would become a bit boring since we wouldn't actually use anything from ~const Aux. With T::generate() nightly rustc incorrectly fails with mismatched types // expected `host`, found `true` since the ICE is a delayed bug. Ofc I could add revisions to this test or another file.
There was a problem hiding this comment.
It's not that big of a deal. Showing that it doesn't ICE (we can lower the where clause) and that it works correctly seems like a fine test.
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 7, 2024
…-impls, r=compiler-errors Support `~const` in associated functions in trait impls Fixes rust-lang#119700.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#116129 (Rewrite `pin` module documentation to clarify usage and invariants) - rust-lang#119702 (Miri subtree update) - rust-lang#119703 (Impl trait tweaks) - rust-lang#119705 (Support `~const` in associated functions in trait impls) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116129 (Rewrite `pin` module documentation to clarify usage and invariants) - rust-lang#119703 (Impl trait diagnostic tweaks) - rust-lang#119705 (Support `~const` in associated functions in trait impls) - rust-lang#119708 (Unions are not `PointerLike`) - rust-lang#119711 (Delete unused makefile in tests/ui) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
Rollup merge of rust-lang#119705 - fmease:tilde-const-assoc-fns-trait-impls, r=compiler-errors Support `~const` in associated functions in trait impls Fixes rust-lang#119700.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119700.