Don't use raw parameter types in find_builder_fn
#121323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
reviewed
Feb 20, 2024
Comment on lines
+1603
to
+1604
| .instantiate(self.tcx, self.fresh_args_for_item(DUMMY_SP, item.def_id)) | ||
| .output(); |
There was a problem hiding this comment.
Suggested change
| .instantiate(self.tcx, self.fresh_args_for_item(DUMMY_SP, item.def_id)) | |
| .output(); | |
| .output() | |
| .instantiate(self.tcx, self.fresh_args_for_item(DUMMY_SP, item.def_id)); |
There was a problem hiding this comment.
EarlyBinder::output() doesnt exist
There was a problem hiding this comment.
Oh heh. I was looking at polyfnsig
There was a problem hiding this comment.
yeah I think youre thinking of the late binder, not early binder haha
oli-obk
approved these changes
Feb 20, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#119203 (Correct the simd_masked_{load,store} intrinsic docs) - rust-lang#121277 (Refactor trait implementations in `core::convert::num`.) - rust-lang#121322 (Don't ICE when hitting overflow limit in fulfillment loop in next solver) - rust-lang#121323 (Don't use raw parameter types in `find_builder_fn`) - rust-lang#121344 (Expand weak alias types before collecting constrained/referenced late bound regions + refactorings) - rust-lang#121350 (Fix stray trait mismatch in `resolve_associated_item` for `AsyncFn`) - rust-lang#121352 (docs: add missing "the" to `str::strip_prefix` doc) Failed merges: - rust-lang#121340 (bootstrap: apply most of clippy's suggestions) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup merge of rust-lang#121323 - compiler-errors:raw-param-types, r=oli-obk Don't use raw parameter types in `find_builder_fn` We shouldn't really ever be using `EarlyBinder::skip_binder` then performing type equality, since param types will never be equal to other types. When checking compatibility with the signature, we instead create some fresh args. Fixes rust-lang#121314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't really ever be using
EarlyBinder::skip_binderthen performing type equality, since param types will never be equal to other types. When checking compatibility with the signature, we instead create some fresh args.Fixes #121314