add more ice tests #122863
add more ice tests #122863
Conversation
rustbot
added
S-waiting-on-review
| for<C2: , R2, R3: > <&str as IntoIterator>::Item: 'static, | ||
| //~^ ERROR `&` without an explicit lifetime name cannot be used here | ||
| //~^^ ERROR only lifetime parameters can be used in this context | ||
| {} |
There was a problem hiding this comment.
I would expecct that this file is still not minimized for this ICE
and believe that most of the syntax issues don't contribute to the ICE and make it more likely this tests ends up being ineffective once we change the way we handle such errors when continuing compilation.
It would be nice to manually spend a few minutes trying to fix all unrelated errors while tracking whether the ICE still triggers.
There was a problem hiding this comment.
well what you call "syntax issues" I call "additional coverage" 😄
There was a problem hiding this comment.
what I mean is, we want tests to also protect against future ICEs and minimizing everything to the absolute minimum just reduces the effectiveness in that regard
There was a problem hiding this comment.
I'll use the example from #113017 (comment)
| @@ -0,0 +1,52 @@ | |||
| // test for #110696 | |||
| // failed to resolve instance for <Scope<()> as MyIndex<()>>::my_index | |||
| // ignore-tidy-linelength | |||
There was a problem hiding this comment.
instead of that adapt the formatting/don't use the full message for the expected error? 🤔
|
@bors delegate+ |
|
✌️ @matthiaskrgr, you can now approve this pull request! If @lcnr told you to " |
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#122863 - matthiaskrgr:teest, r=lcnr add more ice tests fixes rust-lang#119275 fixes rust-lang#113017 fixes rust-lang#112824 fixes rust-lang#112823 fixes rust-lang#121472 fixes rust-lang#110696
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121619 (Experimental feature postfix match) - rust-lang#122370 (Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()`) - rust-lang#122537 (interpret/allocation: fix aliasing issue in interpreter and refactor getters a bit) - rust-lang#122542 (coverage: Clean up marker statements that aren't needed later) - rust-lang#122800 (Add `NonNull::<[T]>::is_empty`.) - rust-lang#122820 (Stop using `<DefId as Ord>` in various diagnostic situations) - rust-lang#122847 (Suggest `RUST_MIN_STACK` workaround on overflow) - rust-lang#122855 (Fix Itanium mangling usizes) - rust-lang#122863 (add more ice tests ) r? `@ghost` `@rustbot` modify labels: rollup
fixes #119275
fixes #113017
fixes #112824
fixes #112823
fixes #121472
fixes #110696