Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for #90192 #122886

Merged
merged 1 commit into from
Mar 24, 2024
Merged

add test for #90192 #122886

merged 1 commit into from
Mar 24, 2024

Conversation

matthiaskrgr
Copy link
Member

Fixes #90192

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2024

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2024
fee1-dead
fee1-dead requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the way revisions are used here. Could you please split and create a new test instead? Also would be better to rename the issue-* to make them more descriptive.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2024
@matthiaskrgr
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2024
@fee1-dead
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 24, 2024

📌 Commit fc5085d has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 24, 2024
@matthiaskrgr
Rollup merge of rust-lang#122886 - matthiaskrgr:issue90192, r=fee1-dead
ed3e660 
add test for rust-lang#90192

Fixes rust-lang#90192
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 24, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2024
@bors
Auto merge of rust-lang#123000 - matthiaskrgr:rollup-pa6cygu, r=matth…
83c1f7c 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#122737 (conditionally ignore fatal diagnostic in the SilentEmitter)
 - rust-lang#122757 (Fixed the `private-dependency` bug)
 - rust-lang#122886 (add test for rust-lang#90192)
 - rust-lang#122937 (Unbox and unwrap the contents of `StatementKind::Coverage`)
 - rust-lang#122949 (Add a regression test for rust-lang#117310)
 - rust-lang#122962 (Track run-make-support lib in common inputs stamp)
 - rust-lang#122977 (Rename `Arguments::as_const_str` to `as_statically_known_str`)
 - rust-lang#122983 (Fix build failure on ARM/AArch64/PowerPC/RISC-V FreeBSD/NetBSD)
 - rust-lang#122984 (panic-in-panic-hook: formatting a message that's just a string is risk-free)
 - rust-lang#122992 (std::thread: refine available_parallelism for solaris/illumos.)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2024
@bors
Auto merge of rust-lang#123004 - matthiaskrgr:rollup-s3v4p50, r=matth…
d36bdd1 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#122737 (conditionally ignore fatal diagnostic in the SilentEmitter)
 - rust-lang#122757 (Fixed the `private-dependency` bug)
 - rust-lang#122886 (add test for rust-lang#90192)
 - rust-lang#122937 (Unbox and unwrap the contents of `StatementKind::Coverage`)
 - rust-lang#122949 (Add a regression test for rust-lang#117310)
 - rust-lang#122962 (Track run-make-support lib in common inputs stamp)
 - rust-lang#122977 (Rename `Arguments::as_const_str` to `as_statically_known_str`)
 - rust-lang#122983 (Fix build failure on ARM/AArch64/PowerPC/RISC-V FreeBSD/NetBSD)
 - rust-lang#122984 (panic-in-panic-hook: formatting a message that's just a string is risk-free)
 - rust-lang#122992 (std::thread: refine available_parallelism for solaris/illumos.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 702261d into rust-lang:master Mar 24, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2024
@rust-timer
Unrolled build for rust-lang#122886
f1d75b1 
Rollup merge of rust-lang#122886 - matthiaskrgr:issue90192, r=fee1-dead

add test for rust-lang#90192

Fixes rust-lang#90192
RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024
@matthiaskrgr @RenjiSann
Rollup merge of rust-lang#122886 - matthiaskrgr:issue90192, r=fee1-dead
e883bf9 
add test for rust-lang#90192

Fixes rust-lang#90192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

ICE: issue-74614.rs with debug asserstions, mir-opt-level=3 and polymorphizations
4 participants
@matthiaskrgr @rustbot @fee1-dead @bors