In ConstructCoroutineInClosureShim, pass receiver by mut ref, not mut pointer
#123049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
compiler-errors
commented
Mar 25, 2024
| @@ -0,0 +1,40 @@ | |||
| #![feature(async_closure, noop_waker, async_fn_traits)] | |||
There was a problem hiding this comment.
Moved the old test from async-closure.rs -> async-closure-drop.rs and then added a new test that tests the calling at async-closure.rs. I wish git were smarter about renames like that lol.
RalfJung
reviewed
Mar 25, 2024
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing newline at end of file
This comment has been minimized.
This comment has been minimized.
|
I'll bless mir-opt and fix formatting on test when I get off the subway |
oli-obk
approved these changes
Mar 25, 2024
compiler-errors
force-pushed
the
coroutine-closure-rcvr
branch
from
dce205b
to
417d310
Compare
compiler-errors
force-pushed
the
coroutine-closure-rcvr
branch
from
417d310
to
22bc5c5
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Mar 26, 2024
…rcvr, r=oli-obk In `ConstructCoroutineInClosureShim`, pass receiver by mut ref, not mut pointer The receivers were compatible at codegen time, but did not necessarily have the same layouts due to niches, which was caught by miri. Fixes rust-lang/miri#3400 r? oli-obk
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108675 (Document `adt_const_params` feature in Unstable Book) - rust-lang#122120 (Suggest associated type bounds on problematic associated equality bounds) - rust-lang#122589 (Fix diagnostics for async block cloning) - rust-lang#122835 (Require `DerefMut` and `DerefPure` on `deref!()` patterns when appropriate) - rust-lang#123049 (In `ConstructCoroutineInClosureShim`, pass receiver by mut ref, not mut pointer) - rust-lang#123055 (enable cargo miri test doctests) - rust-lang#123057 (unix fs: Make hurd using explicit new rather than From) - rust-lang#123087 (Change `f16` and `f128` clippy stubs to be nonpanicking) - rust-lang#123103 (Rename `Inherited` -> `TypeckRootCtxt`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2024
Rollup merge of rust-lang#123049 - compiler-errors:coroutine-closure-rcvr, r=oli-obk In `ConstructCoroutineInClosureShim`, pass receiver by mut ref, not mut pointer The receivers were compatible at codegen time, but did not necessarily have the same layouts due to niches, which was caught by miri. Fixes rust-lang/miri#3400 r? oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receivers were compatible at codegen time, but did not necessarily have the same layouts due to niches, which was caught by miri.
Fixes rust-lang/miri#3400
r? oli-obk