Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: add a couple of regression tests #123348

Merged
merged 1 commit into from
Apr 2, 2024
Merged

rustdoc: add a couple of regression tests #123348

merged 1 commit into from
Apr 2, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented Apr 2, 2024 •
edited
Loading

Fixes #114657.
Fixes #112828.
Fixes #107715.

r? rustdoc

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 2, 2024
GuillaumeGomez
GuillaumeGomez reviewed Apr 2, 2024
View reviewed changes
tests/rustdoc-ui/synthetic-auto-trait-impls/const-in-super-trait-and-item-bound.rs Outdated
@@ -0,0 +1,23 @@
// We you used to ICE here while trying to synthesize auto trait impls.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"We you used"? 😉

GuillaumeGomez
GuillaumeGomez approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me once typos are fixed.

@fmease fmease force-pushed the add-synth-auto-trait-impls-tests branch from 6af717a to f45eaf8 Compare April 2, 2024 10:31
@fmease
Copy link
Member Author

fmease commented Apr 2, 2024

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Apr 2, 2024

📌 Commit f45eaf8 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2024
@bors
Copy link
Contributor

bors commented Apr 2, 2024

⌛ Testing commit f45eaf8 with merge f03ff3d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
@bors
Auto merge of rust-lang#123348 - fmease:add-synth-auto-trait-impls-te…
f03ff3d 
…sts, r=GuillaumeGomez

rustdoc: add a couple of regression tests

Fixes rust-lang#114657.
Fixes rust-lang#112828.
Fixes rust-lang#112242.
Fixes rust-lang#107715.

r? rustdoc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 2, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 2, 2024
@fmease
Copy link
Member Author

fmease commented Apr 2, 2024

o.O

@GuillaumeGomez
Copy link
Member

Maybe it's because of changes in your other PR?

@fmease
Copy link
Member Author

fmease commented Apr 2, 2024 •
edited
Loading

Right, I've intentionally changed a vid_map.get(vid).unwrap_or(r) to a vid_map[vid] making rustdoc panic if rustc::AutoTraitFinder returns a region inference variable that cannot be resolved because that is really fishy. I can change it back with a FIXME: investigate which would also fix #123370 or remove the failing test from this PR and readd it once I understand rustc::AutoTraitFinder and can fix the underlying issue if there's one.

rustc::AutoTraitFinder can also return placeholder regions RePlaceholder which doesn't seem right either and which makes rustdoc ICE, too (we have a GitHub issue for that already).

@fmease
Copy link
Member Author

fmease commented Apr 2, 2024 •
edited
Loading

Should I implement the hot fix (single line change back to the old behavior) to fix the regressions from my simplification PR or should I postpone?

@GuillaumeGomez
Copy link
Member

Remove the failing test from here and do the hotfix in another PR?

@fmease fmease force-pushed the add-synth-auto-trait-impls-tests branch from f45eaf8 to 5ee4d13 Compare April 2, 2024 16:38
@fmease
Copy link
Member Author

fmease commented Apr 2, 2024

I've removed the failing test. Hot fix coming up in a sec.
@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Apr 2, 2024

📌 Commit 5ee4d13 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2024
@fmease fmease mentioned this pull request Apr 2, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#123348 - fmease:add-synth-auto-trait-impls-…
3c90cfa 
…tests, r=GuillaumeGomez

rustdoc: add a couple of regression tests

Fixes rust-lang#114657.
Fixes rust-lang#112828.
Fixes rust-lang#107715.

r? rustdoc
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#123375 - fmease:rustdoc-sati-re-hotfix, r=G…
f88a33c 
…uillaumeGomez

rustdoc: synthetic auto trait impls: accept unresolved region vars for now

rust-lang#123348 (comment):

> Right, [in rust-lang#123340] I've intentionally changed a `vid_map.get(vid).unwrap_or(r)` to a `vid_map[vid]` making rustdoc panic if `rustc::AutoTraitFinder` returns a region inference variable that cannot be resolved because that is really fishy.  I can change it back with a `FIXME: investigate` […]. [O]nce I [fully] understand [the arcane] `rustc::AutoTraitFinder` [I] can fix the underlying issue if there's one.
>
> `rustc::AutoTraitFinder` can also return placeholder regions `RePlaceholder` which doesn't seem right either and which makes rustdoc ICE, too (we have a GitHub issue for that already[, namely rust-lang#120606]).

Fixes rust-lang#123370.
Fixes rust-lang#112242.

r? `@GuillaumeGomez`
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 2, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#123375 - fmease:rustdoc-sati-re-hotfix, r=G…
8e271d7 
…uillaumeGomez

rustdoc: synthetic auto trait impls: accept unresolved region vars for now

rust-lang#123348 (comment):

> Right, [in rust-lang#123340] I've intentionally changed a `vid_map.get(vid).unwrap_or(r)` to a `vid_map[vid]` making rustdoc panic if `rustc::AutoTraitFinder` returns a region inference variable that cannot be resolved because that is really fishy.  I can change it back with a `FIXME: investigate` […]. [O]nce I [fully] understand [the arcane] `rustc::AutoTraitFinder` [I] can fix the underlying issue if there's one.
>
> `rustc::AutoTraitFinder` can also return placeholder regions `RePlaceholder` which doesn't seem right either and which makes rustdoc ICE, too (we have a GitHub issue for that already[, namely rust-lang#120606]).

Fixes rust-lang#123370.
Fixes rust-lang#112242.

r? ``@GuillaumeGomez``
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
@bors
Auto merge of rust-lang#123385 - matthiaskrgr:rollup-v69vjbn, r=matth…
88c2f4f 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#123198 (Add fn const BuildHasherDefault::new)
 - rust-lang#123226 (De-LLVM the unchecked shifts [MCP#693])
 - rust-lang#123302 (Make sure to insert `Sized` bound first into clauses list)
 - rust-lang#123348 (rustdoc: add a couple of regression tests)
 - rust-lang#123362 (Check that nested statics in thread locals are duplicated per thread.)
 - rust-lang#123368 (CFI: Support non-general coroutines)
 - rust-lang#123375 (rustdoc: synthetic auto trait impls: accept unresolved region vars for now)
 - rust-lang#123378 (Update sysinfo to 0.30.8)

Failed merges:

 - rust-lang#123349 (Fix capture analysis for by-move closure bodies)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 464f264 into rust-lang:master Apr 2, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
@rust-timer
Unrolled build for rust-lang#123375
a2c57eb 
Rollup merge of rust-lang#123375 - fmease:rustdoc-sati-re-hotfix, r=GuillaumeGomez

rustdoc: synthetic auto trait impls: accept unresolved region vars for now

rust-lang#123348 (comment):

> Right, [in rust-lang#123340] I've intentionally changed a `vid_map.get(vid).unwrap_or(r)` to a `vid_map[vid]` making rustdoc panic if `rustc::AutoTraitFinder` returns a region inference variable that cannot be resolved because that is really fishy.  I can change it back with a `FIXME: investigate` […]. [O]nce I [fully] understand [the arcane] `rustc::AutoTraitFinder` [I] can fix the underlying issue if there's one.
>
> `rustc::AutoTraitFinder` can also return placeholder regions `RePlaceholder` which doesn't seem right either and which makes rustdoc ICE, too (we have a GitHub issue for that already[, namely rust-lang#120606]).

Fixes rust-lang#123370.
Fixes rust-lang#112242.

r? ``@GuillaumeGomez``
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
@rust-timer
Unrolled build for rust-lang#123348
4d28bdd 
Rollup merge of rust-lang#123348 - fmease:add-synth-auto-trait-impls-tests, r=GuillaumeGomez

rustdoc: add a couple of regression tests

Fixes rust-lang#114657.
Fixes rust-lang#112828.
Fixes rust-lang#107715.

r? rustdoc
@fmease fmease deleted the add-synth-auto-trait-impls-tests branch April 2, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
5 participants
@fmease @bors @rust-log-analyzer @GuillaumeGomez @rustbot