Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect outer function type parameter message #53960

Merged
merged 3 commits into from
Sep 9, 2018

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 5, 2018

Fix #51303.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2018
@estebank
Copy link
Contributor Author

estebank commented Sep 5, 2018

[do not merge yet] I think it'd be nice if we actually provided a suggestion to use whatever Self is when possible (impl Foo should suggest Foo, while impl Bar for Foo should keep the current diagnostic).

cc @nagisa

}) {
err.span_label(
reduce_impl_span_to_impl_keyword(cm, impl_span),
"`Self` type implicitly declared here, on the `impl`",
Copy link
Member

@nagisa nagisa Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/on the/by this/

@nagisa
Copy link
Member

nagisa commented Sep 5, 2018

This seems good to merge with fixed wording.

@estebank
Copy link
Contributor Author

estebank commented Sep 6, 2018

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Sep 6, 2018

📌 Commit bebecf8 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Sep 7, 2018
Fix incorrect outer function type parameter message

Fix rust-lang#51303.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 8, 2018
Fix incorrect outer function type parameter message

Fix rust-lang#51303.
@bors
Copy link
Contributor

bors commented Sep 9, 2018

⌛ Testing commit bebecf8 with merge dac7602...

bors added a commit that referenced this pull request Sep 9, 2018
Fix incorrect outer function type parameter message

Fix #51303.
@bors
Copy link
Contributor

bors commented Sep 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing dac7602 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants