Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE with save-analysis #68756

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

JohnTitor
Copy link
Member

Fixes #68749

It should be fine since it's the same way as visit_expr.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2020
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 2, 2020

📌 Commit c377ed6 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2020
@bors
Copy link
Contributor

bors commented Feb 3, 2020

⌛ Testing commit c377ed6 with merge a2e8030...

bors added a commit that referenced this pull request Feb 3, 2020
Fix ICE with save-analysis

Fixes #68749

It should be fine since it's the same way as `visit_expr`.
@bors
Copy link
Contributor

bors commented Feb 3, 2020

☀️ Test successful - checks-azure
Approved by: davidtwco
Pushing a2e8030 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 3, 2020
@bors bors merged commit c377ed6 into rust-lang:master Feb 3, 2020
@JohnTitor JohnTitor deleted the fix-ice-save-analysis-2 branch February 3, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ice on glacier 26459.rs with -Zsave-analysis
4 participants