save_analysis: better handle paths and functions signature #73155
Conversation
rust-highfive
added
the
S-waiting-on-review
| unsafety: hir::Unsafety::Unsafe, | ||
| // functions in extern block cannot be const | ||
| constness: hir::Constness::NotConst, | ||
| abi: self.tcx.hir().get_foreign_abi(item.hir_id), |
There was a problem hiding this comment.
I managed to get the real abi of the extern block using get_foreign_abi. I don't think we should change the hir to store a FnHeader in ForeignItem::Fn. I tried it locally, it works, but its really invasive and somehow orthogonal to this change.
There was a problem hiding this comment.
I think you're right, let's stick with what we have. Thanks!
marmeladema
force-pushed
the
save-analysis-various-fixes
branch
from
664db1b
to
5bfa7f0
Compare
| unsafety: hir::Unsafety::Unsafe, | ||
| // functions in extern block cannot be const | ||
| constness: hir::Constness::NotConst, | ||
| abi: self.tcx.hir().get_foreign_abi(item.hir_id), |
There was a problem hiding this comment.
I think you're right, let's stick with what we have. Thanks!
|
@bors r+ |
|
📌 Commit 5bfa7f0 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 11 pull requests Successful merges: - rust-lang#72380 (Fix `is_const_context`, update `check_for_cast`) - rust-lang#72941 (Ensure stack when building MIR for matches) - rust-lang#72976 (Clean up E0642 explanation) - rust-lang#73080 (doc/rustdoc: Fix incorrect external_doc feature flag) - rust-lang#73155 (save_analysis: better handle paths and functions signature) - rust-lang#73164 (Add new E0762 error code) - rust-lang#73172 (Fix more clippy warnings) - rust-lang#73181 (Automatically prioritize unsoundness issues) - rust-lang#73183 (Support proc macros in intra doc link resolution) - rust-lang#73208 (Fix doctest template) - rust-lang#73219 (x.py: with --json-output, forward cargo's JSON) Failed merges: r? @ghost
|
Thanks @marmeladema for fixing the bug! I've thought that with rls around the corner it would never be fixed. |
|
I am actually using save-analysis issues as a way to learn more about the compiler 👍 |
This should improve slightly some possible regressions due to hir rework.
r? @Xanewok