Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #74908

Merged
merged 1 commit into from
Jul 30, 2020
Merged

update Miri #74908

merged 1 commit into from
Jul 30, 2020
+2 −2

Conversation

RalfJung
Copy link
Member

Fixes #74580
Cc @rust-lang/miri r? @ghost

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 29, 2020

📌 Commit d3539c78f665fc8ad8a121361512d6d35a81e3df has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 29, 2020
@bors
Copy link
Contributor

bors commented Jul 29, 2020

⌛ Testing commit d3539c78f665fc8ad8a121361512d6d35a81e3df with merge 86f24300a3c3680965378e1d7ca86081b16373a5...

@RalfJung
Copy link
Member Author

Tools PR CI failed.
@bors retry r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2020
@RalfJung RalfJung force-pushed the miri branch 2 times, most recently from 43235df to e63540a Compare July 29, 2020 17:08
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 29, 2020

📌 Commit e63540ae6529389a09c1d672b9276c7eab2b05fa has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2020
@bors
Copy link
Contributor

bors commented Jul 29, 2020

⌛ Testing commit e63540ae6529389a09c1d672b9276c7eab2b05fa with merge 5a3043c8e857eefc4c6d09039f767af9d011722e...

@bors
Copy link
Contributor

bors commented Jul 29, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2020
@RalfJung
Copy link
Member Author

I have no idea what this test failure is about:

2020-07-29T20:34:20.6114553Z failures:
2020-07-29T20:34:20.6114835Z 
2020-07-29T20:34:20.6118059Z ---- build::close_output stdout ----
2020-07-29T20:34:20.6123835Z thread 'build::close_output' panicked at 'assertion failed: !status.success()', src/tools/cargo/tests/testsuite/build.rs:5016:9
2020-07-29T20:34:20.6124329Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-07-29T20:34:20.6124435Z 
2020-07-29T20:34:20.6124690Z 
2020-07-29T20:34:20.6125074Z failures:
2020-07-29T20:34:20.6126826Z     build::close_output

@Mark-Simulacrum any idea?

I cannot see Miri tests even being run in this PR, so let's hope this is spurious.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2020
@Mark-Simulacrum
Copy link
Member

cc rust-lang/cargo#8564 @ehuss

Indeed spurious.

@RalfJung
Copy link
Member Author

@bors r-
A miri-breaking change landed in the mean time

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 30, 2020
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 30, 2020

📌 Commit 1a2208a has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2020
@bors
Copy link
Contributor

bors commented Jul 30, 2020

⌛ Testing commit 1a2208a with merge 438c59f...

@bors
Copy link
Contributor

bors commented Jul 30, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: RalfJung
Pushing 438c59f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 30, 2020
@bors bors merged commit 438c59f into rust-lang:master Jul 30, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #74908!

Tested on commit 438c59f.
Direct link to PR: #74908

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 30, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#74908!
9442f0d 
Tested on commit rust-lang/rust@438c59f.
Direct link to PR: <rust-lang/rust#74908>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
@RalfJung RalfJung deleted the miri branch July 31, 2020 08:13
@ehuss ehuss mentioned this pull request Aug 2, 2020
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2023
Closed
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#69749
5 participants
@RalfJung @bors @Mark-Simulacrum @rust-highfive @cuviper