Rollup of 10 pull requests #74929
Merged
Rollup of 10 pull requests #74929
+373
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn about unused expressions with closure or generator type. This follows
existing precedence of must use annotations present on `FnOnce`, `FnMut`, `Fn`
traits, which already indirectly apply to closures in some cases, e.g.,:
```rust
fn f() -> impl FnOnce() {
|| {}
}
fn main() {
// an existing warning: unused implementer of `std::ops::FnOnce` that must be used:
f();
// a new warning: unused closure that must be used:
|| {};
}
```
This does not actually alter the previously specified important parts, but apparently `rustc` cares about more layout components than `cargo-xbuild` ever did. This extends the data layout to be fully specified layout, as given in the error from issue rust-lang#74767
…d-errata, r=nikomatsakis Remove links to rejected errata 4406 for RFC 4291 Fixes rust-lang#74198. For now I simply removed the links, the docs seems clear enough to me but I'm no expert in the domain so don't hesitate to correct me if more is needed. cc @ghanan94. @rustbot modify labels: T-doc, T-libs
Point towards `format_spec`; it is in other direction
…rcote Explain why inlining default ToString impl Trying to remove inline attribute from default ToString impl causes regression. Perf result at <rust-lang#74852 (comment)>.
…ic-morse
Make closures and generators a must use types
Warn about unused expressions with closure or generator type. This follows
existing precedence of must use annotations present on `FnOnce`, `FnMut`, `Fn`
traits, which already indirectly apply to closures in some cases, e.g.,:
```rust
fn f() -> impl FnOnce() {
|| {}
}
fn main() {
// an existing warning: unused implementer of `std::ops::FnOnce` that must be used:
f();
// a new warning: unused closure that must be used:
|| {};
}
```
Closes rust-lang#74691.
symbol mangling: use ty::print::Print for consts r? @eddyb
Remove deprecated unstable `{Box,Rc,Arc}::into_raw_non_null` functions
FCP: rust-lang#47336 (comment)
…evink Fix some typos in src/librustdoc/clean/auto_trait.rs
fence docs: fix example Mutex Fixes rust-lang#74808 Cc @pca006132
…le_plugin_book, r=jonas-schievink Fix broken link in unstable book `plugin` There is broken link in https://doc.rust-lang.org/unstable-book/language-features/plugin.html#lint-plugins.
…schievink Change the target data layout to specify more values This does not actually alter the previously specified important parts, but apparently `rustc` cares about more layout components than `cargo-xbuild` ever did. This extends the data layout to be a fully specified layout, as given in the error from issue rust-lang#74767 * Closes rust-lang#74767
|
📌 Commit f4f77d7 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
format_spec; it is in other direction #74819 (Point towardsformat_spec; it is in other direction){Box,Rc,Arc}::into_raw_non_nullfunctions #74902 (Remove deprecated unstable{Box,Rc,Arc}::into_raw_non_nullfunctions)plugin#74912 (Fix broken link in unstable bookplugin)Failed merges:
r? @ghost