Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #79138

Merged
merged 25 commits into from
Nov 17, 2020
Merged

Rollup of 8 pull requests #79138

merged 25 commits into from
Nov 17, 2020

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Nov 17, 2020

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

wesleywiser and others added 25 commits November 3, 2020 07:55
This is helpful when looking for CGUs where the size estimate isn't a
good indicator of compilation time.

I verified that moving the profiling timer call doesn't affect the
results.
This is mostly me learning the codebase, so feel free to close the PR.
It does have the small benefit that we statically know rustdoc isn't
generating useless `span`s, though.
It's the same as clean::Function.
Replace it instead with `(clean::Function, Option<hir::Defaultness>)`.
It was exactly the same as `is_auto`.
…r-output-color, r=jyn514

Rustdoc test compiler output color

Fixes rust-lang#72915

We just need to be sure it doesn't break rustdoc doctests' compilation checks. Maybe some other unforeseen consequences too?

r? `@ehuss`
cc `@rust-lang/rustdoc`
… r=Mark-Simulacrum

[self-profiling] Include the estimated size of each cgu in the profile

This is helpful when looking for CGUs where the size estimate isn't a
good indicator of compilation time.

I verified that moving the profiling timer call doesn't affect the
results.

Results:

<img width="297" alt="Screen Shot 2020-11-03 at 7 25 04 AM" src="https://user-images.githubusercontent.com/831192/97985503-5901d100-1da6-11eb-9f10-f3e399702952.png">

`measureme` doesn't have support for custom arg names yet so `arg0` is the CGU name and `arg1` is the estimated size.
Get rid of `highlight::Class::None`

This is mostly me learning the codebase for rust-lang#77939, so feel free to close the PR.
It does have the small benefit that we statically know rustdoc isn't generating useless `span`s, though.

r? `@GuillaumeGomez`
cc `@matklad`
Fix exhaustiveness in case a byte string literal is used at slice type

fixes rust-lang#79048
Get rid of clean::{Method, TyMethod}

They're redundant and almost the same as `clean::Function`.

I needed this for rust-lang#78082, although I forget why.

r? `@GuillaumeGomez`
Remove duplicate `Trait::auto` field

It was exactly the same as `is_auto`.

I found this while working on rust-lang#78082, but it's not required for that PR.

r? `@GuillaumeGomez`
extend macro braces test

r? `@varkor`
@rustbot rustbot added the rollup A PR which is a rollup label Nov 17, 2020
@m-ou-se
Copy link
Member Author

m-ou-se commented Nov 17, 2020

@bors r+ p=8 rollup=never

@bors
Copy link
Contributor

bors commented Nov 17, 2020

📌 Commit f698505 has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 17, 2020
@bors
Copy link
Contributor

bors commented Nov 17, 2020

⌛ Testing commit f698505 with merge c919f49...

@bors
Copy link
Contributor

bors commented Nov 17, 2020

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing c919f49 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 17, 2020
@bors bors merged commit c919f49 into rust-lang:master Nov 17, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 17, 2020
@m-ou-se m-ou-se deleted the rollup-owel5ld branch November 17, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants