Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect Box::from_raw_in doctest #84053

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Conversation

RalfJung
Copy link
Member

Now that Miri can run doctests, I ran it on liballoc, and found exactly one problem: this test creates a Box<u8> to deallocate a 4-byte allocation!

Introduced by #80310 so r? @Manishearth @kennytm

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2021

📌 Commit 63b682b has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2021
@bors
Copy link
Contributor

bors commented Apr 11, 2021

⌛ Testing commit 63b682b with merge ef38b45...

@bors
Copy link
Contributor

bors commented Apr 11, 2021

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing ef38b45 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 11, 2021
@bors bors merged commit ef38b45 into rust-lang:master Apr 11, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 11, 2021
@RalfJung RalfJung deleted the liballoc-miri branch April 11, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants