Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline asm! tests for aarch64 #87584

Merged
merged 2 commits into from
Sep 25, 2021
Merged

Add inline asm! tests for aarch64 #87584

merged 2 commits into from
Sep 25, 2021

Conversation

adamgemmell
Copy link
Contributor

Port many of the x86-only UI tests for inline asm! over to aarch64.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2021
@Mark-Simulacrum
Copy link
Member

r? @Amanieu

@Amanieu
Copy link
Member

Amanieu commented Aug 2, 2021

Rather than adding a -x86_64 or -aarch64 suffix, could you instead move the tests into x86_64/ and aarch64/ directories?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@adamgemmell
Copy link
Contributor Author

Rebase & rebless fixes the test failure. This branch could probably do with squashing when merging

@Amanieu
Copy link
Member

Amanieu commented Aug 11, 2021

LGTM, can you squash the commits before merging?

@Amanieu
Copy link
Member

Amanieu commented Aug 14, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 14, 2021

📌 Commit b634d85e787ea2f3b47ec6e73752b542445775e9 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2021
@bors
Copy link
Contributor

bors commented Aug 15, 2021

☔ The latest upstream changes (presumably #87581) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2021
@adamgemmell adamgemmell marked this pull request as draft August 16, 2021 08:57
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@adamgemmell
Copy link
Contributor Author

More conflicts/changes from master - I'll of course squash again once you've taken a look at them

@Amanieu
Copy link
Member

Amanieu commented Aug 18, 2021

LGTM

@adamgemmell adamgemmell marked this pull request as ready for review August 18, 2021 14:09
@Amanieu
Copy link
Member

Amanieu commented Aug 21, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 21, 2021

📌 Commit d1fddf0bda94cee7ea6ddca49b8e2b00d149e494 has been approved by Amanieu

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 21, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Aug 21, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2021
@inquisitivecrystal inquisitivecrystal added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Aug 24, 2021
@bors
Copy link
Contributor

bors commented Aug 28, 2021

⌛ Testing commit d1fddf0bda94cee7ea6ddca49b8e2b00d149e494 with merge 7ebe62cd40ee5120fbbba8ada8835b8d1b85e168...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Aug 28, 2021

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Aug 28, 2021

Note that webassembly has inline asm but doesn't have the reg register class. It uses local instead.

@bors
Copy link
Contributor

bors commented Sep 3, 2021

☔ The latest upstream changes (presumably #88597) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

ping from triage:
@adamgemmell
Returning to you to address merge conflicts and after that, please switch back to S-waiting-on-review.
thanks.

@rustbot label: +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2021
@adamgemmell
Add inline asm! tests for aarch64
6d218d0 
Enable tests which are largely architecture-independent on all supported
platforms
@adamgemmell
Disable some tests for platforms without registers.
27213b0 
Update new tests to run on aarch64 platforms.
@adamgemmell
Copy link
Contributor Author

Sorry for the delay on this one. Opted to disable tests requiring a reg class. There were also a few new test files posted upstream since the last update.

@Amanieu
Copy link
Member

Amanieu commented Sep 25, 2021

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Sep 25, 2021

📌 Commit 27213b0 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 25, 2021
@bors
Copy link
Contributor

bors commented Sep 25, 2021

⌛ Testing commit 27213b0 with merge 9620f3a...

@bors
Copy link
Contributor

bors commented Sep 25, 2021

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 9620f3a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 25, 2021
@bors bors merged commit 9620f3a into rust-lang:master Sep 25, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 25, 2021
@bors bors mentioned this pull request Sep 25, 2021
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9620f3a): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@gurry gurry mentioned this pull request Dec 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
10 participants
@adamgemmell @rust-highfive @Mark-Simulacrum @Amanieu @rust-log-analyzer @bors @JohnCSimon @rust-timer @inquisitivecrystal @rustbot