Fix loading large rlibs #88506
Fix loading large rlibs #88506
Conversation
Bumps object crate to permit parsing archives with 64-bit table entries. These are primarily encountered when there's more than 4GB of archive data.
Mark-Simulacrum
added
beta-nominated
rust-highfive
added
the
S-waiting-on-review
|
beta-accepting myself since if we're OK with master we're probably good with backporting, small patch and fixes a clear regression. |
|
Hm, maybe I'm confused, but I don't think this test can be checked in as-is? On my relatively fast system it takes almost 15 minutes to finish, and uses 16 GB of disk space. Was this just to demonstrate that it is fixed? I don't have any particular ideas on how to make a test that could be feasible. Perhaps write some hand-crafted ELF files that circumvents Otherwise, seems like the test passes locally for me. |
|
Yeah, I think the test as-is does likely take too long. I'll probably drop it from this PR later today- I sort of want a slow test mode but 11-15 minutes seems excessive on any system for a singles test. |
This is kept to a separate commit so that the test itself is preserved in the commit history.
|
@ehuss would you be up for r+'ing this now? I just pushed a commit that deletes the test; I opted for a separate commit because it seems nice to keep the test around in the commit history so we can cherry-pick just the first commit for testing purposes. Happy to squash if you disagree though. |
|
👍 Not sure if you want to adjust the priority. |
|
📌 Commit 84df1ed has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 Yeah, I'd like to get this landed so we can have the backport this week without too much hassle. |
|
☀️ Test successful - checks-actions |
Mark-Simulacrum
removed
the
beta-nominated
…ulacrum [beta] backports This PR backports: * Concrete regions can show up in mir borrowck if the originated from there rust-lang#88533 (fixes rust-lang#83190) * Fix loading large rlibs rust-lang#88506 (fixes rust-lang#88351) * Display associated types of implementors rust-lang#88490 (fixes rust-lang#86631) * Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS rust-lang#88397 r? `@Mark-Simulacrum`
Bumps object crate to permit parsing archives with 64-bit table entries. These
are primarily encountered when there's more than 4GB of archive data.
cc gimli-rs/object#365
Helps with #88351, but will also need a beta backport
r? @ehuss (mostly for the test)