Use try_normalize_erasing_regions in RevealAllVisitor #91875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
Aaron1011
reviewed
Dec 13, 2021
| @@ -36,6 +36,6 @@ impl<'tcx> MutVisitor<'tcx> for RevealAllVisitor<'tcx> { | |||
|
|
|||
| #[inline] | |||
| fn visit_ty(&mut self, ty: &mut Ty<'tcx>, _: TyContext) { | |||
| *ty = self.tcx.normalize_erasing_regions(self.param_env, ty); | |||
| *ty = self.tcx.try_normalize_erasing_regions(self.param_env, *ty).unwrap_or(ty); | |||
There was a problem hiding this comment.
Can you add a comment explaining that the MIR we are visiting might have impossible-to-satiafy where clauses?
b-naber
force-pushed
the
mir-transform-norm-erase-reg
branch
from
48b2f00
to
f3ecd64
Compare
|
Thanks! @bors r+ |
|
📌 Commit f3ecd64 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2021
…g, r=Aaron1011 Use try_normalize_erasing_regions in RevealAllVisitor Fixes rust-lang#91745 Thanks to `@Aaron1011` for [pointing out the problem](rust-lang#91745 (comment)). r? `@Aaron1011`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91529 (add BinaryHeap::try_reserve and BinaryHeap::try_reserve_exact) - rust-lang#91820 (Suggest to specify a target triple when lang item is missing) - rust-lang#91851 (Make `MaybeUninit::zeroed` `const`) - rust-lang#91875 (Use try_normalize_erasing_regions in RevealAllVisitor) - rust-lang#91887 (Remove `in_band_lifetimes` from `rustc_const_eval`) - rust-lang#91892 (Fix HashStable implementation on InferTy) - rust-lang#91893 (Remove `in_band_lifetimes` from `rustc_hir`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91745
Thanks to @Aaron1011 for pointing out the problem.
r? @Aaron1011