Erase regions before calculating layout for packed field capture #92242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc: @arora-aman who wrote #82878, and @nikomatsakis who approved it. Assume y'all know this code best. |
|
Should I add a test for this? Is there a test flag for the existing |
|
I think this change is fine. We erase regions in any information we carry forward in writeback anyway. That said Niko or Mattew probably understand the possible edge cases way better than I do. |
JohnCSimon
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 1458687 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92242 (Erase regions before calculating layout for packed field capture) - rust-lang#93443 (Add comment on stable_hash_impl for OwnerNodes) - rust-lang#93742 (Drop rustc-docs from complete profile) - rust-lang#93852 (rustdoc: remove support for multi-query search) - rust-lang#93853 (Make all `hir::Map` methods consistently by-value) - rust-lang#93861 (Fix ICE if no trait assoc const eq) - rust-lang#93862 (Split x86_64-apple builder into two) - rust-lang#93864 (Remove ArchiveBuilder::update_symbols) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory. We just erase region inferencing because we don't need that for layout computation... Q: layouts are always equal modulo regions, right?
Fixes #92240