-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpilfy thread::JoinInner. #92553
Simpilfy thread::JoinInner. #92553
Conversation
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
FWIW it feels like naively the packet might be better represented as @bors r+ |
📌 Commit a45b3ac has been approved by |
I'll be replacing |
@bors rollup=never (might affect perf, just in case) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (256721e): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
JoinInner
'snative
field was anOption
, but that's unnecessary.Also, thanks to
Arc::get_mut
, there's no unsafety needed inJoinInner::join()
.