Return early to fix ICE

[ouz-a]

This fixes #94627, ICE happens because compiler tries to suggest constraining type parameter but the only constraint is implicit std::Sized one, so it gets removed and there is nothing to suggest resulting in ICE.

[rust-highfive]

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

[compiler-errors]

Perhaps we can fix this issue in a different way. Right above your changes is a call to suggest_removing_unsized_bound -- perhaps we can make that return a bool (signifying if adding the suggestion was successful), and bail in this function if that returns false.

[ouz-a]

Perhaps we can fix this issue in a different way. Right above your changes is a call to suggest_removing_unsized_bound -- perhaps we can make that return a bool (signifying if adding the suggestion was successful), and bail in this function if that returns false.

But there is no sized constraint left so we don't pass sized_constraints.next() check, even if I change the condition so we pass the check, suggest_removing_unsized_bound would be unrelated to what we do here.

[compiler-errors]

Hm.. really? How do we get into that loop if we have no constraints? I would assume the only constraint we had in that loop that get drained in that drain_filter call.

[ouz-a]

Hm.. really? How do we get into that loop if we have no constraints? I would assume the only constraint we had in that loop that get drained in that drain_filter call.

But... drain is inside the loop, we drain the std::marker::Sized then we have nothing left this is why we get ICE in the first place

[oli-obk]

What do you think about not calling multipart_suggestion_verbose if the suggestion list is empty?

[oli-obk]

r? @oli-obk

[ouz-a]

What do you think about not calling multipart_suggestion_verbose if the suggestion list is empty?

It would not matter much. Just would improve readability 😸

if suggestions.len() == 1 {//span_suggestion_verbose}
else if sugesstions.len() > 1 {// multipart}

like this?

[oli-obk]

@bors r+ rollup

Perfect! Thanks

[bors]

📌 Commit 1853ffc has been approved by oli-obk

[bors]

⌛ Testing commit 1853ffc with merge 22a20e3...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 22a20e3 to master...

[rust-timer]

Finished benchmarking commit (22a20e3): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression