Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel a not emitted error after parsing const generic args #95200

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Mar 22, 2022

closes #95163

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 22, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2022
@rust-log-analyzer

This comment has been minimized.

@TaKO8Ki TaKO8Ki force-pushed the cancel-not-emitted-error-when-parsing-generic-arg branch from a278dd5 to 62ded07 Compare March 22, 2022 07:07
@oli-obk
Copy link
Contributor

oli-obk commented Mar 22, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 22, 2022

📌 Commit 62ded07 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 22, 2022
…en-parsing-generic-arg, r=oli-obk

Cancel a not emitted error after parsing const generic args

closes rust-lang#95163
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95188 ([`macro-metavar-expr`] Fix generated tokens hygiene)
 - rust-lang#95196 (rename LocalState::Uninitialized to Unallocated)
 - rust-lang#95197 (Suggest constraining param for unary ops when missing trait impl)
 - rust-lang#95200 (Cancel a not emitted error after parsing const generic args)
 - rust-lang#95207 (update Termination trait docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5d3dfb4 into rust-lang:master Mar 22, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: the following error was constructed but not emitted
6 participants