Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TyCtxt::type_of documentation #95537

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Improve TyCtxt::type_of documentation #95537

merged 1 commit into from
Apr 2, 2022

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 31, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 31, 2022

📌 Commit dd71ce3 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#95537 - GuillaumeGomez:type_of-doc, r=Dylan…
bfbc2e4 
…-DPC

Improve TyCtxt::type_of documentation

r? `@oli-obk`
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 1, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r- looks like it failed in a rollup
#95551 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2022
@GuillaumeGomez
Copy link
Member Author

Should be fixed now.

@bors: r=Dylan-DPC rollup

@bors
Copy link
Contributor

bors commented Apr 1, 2022

📌 Commit 0762470 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#95537 - GuillaumeGomez:type_of-doc, r=Dylan…
e76a694 
…-DPC

Improve TyCtxt::type_of documentation

r? `@oli-obk`
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 1, 2022
Closed
@matthiaskrgr
Copy link
Member

Looks like there are still problems :(
https://github.com/rust-lang-ci/rust/runs/5794302810?check_suite_focus=true#step:26:43642
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2022
@GuillaumeGomez
Copy link
Member Author

Weird, it worked when I built the docs locally... Fixing it tomorrow.

@GuillaumeGomez
Copy link
Member Author

Fixed again.

@bors: r=Dylan-DPC

@bors
Copy link
Contributor

bors commented Apr 2, 2022

📌 Commit 6fdeee4 has been approved by Dylan-DPC

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 2, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 2, 2022
@bors
Copy link
Contributor

bors commented Apr 2, 2022

⌛ Testing commit 6fdeee4 with merge fbc45b6...

@bors
Copy link
Contributor

bors commented Apr 2, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing fbc45b6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2022
@bors bors merged commit fbc45b6 into rust-lang:master Apr 2, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 2, 2022
@GuillaumeGomez GuillaumeGomez deleted the type_of-doc branch April 2, 2022 14:54
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fbc45b6): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@matthiaskrgr matthiaskrgr mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @Dylan-DPC @bors @matthiaskrgr @rust-timer @oli-obk @rust-highfive @rustbot