Support tool lints with the `#[expect]` attribute (RFC 2383) #95542

xFrednet · 2022-03-31T21:06:43Z

This PR fixes the ICE #94953 by making the assert for converted expectation IDs conditional.

Additionally, it moves the lint expectation check into a separate query to support rustdoc and other tools. On the way, I've also added some tests to ensure that the attribute works for Clippy and rustdoc lints.

The number of changes comes from the long test file. This may look like a monster PR, this may smell like a monster PR and this may be a monster PR, but it's a harmless monster. 🦕

Closes: #94953

cc: #85549

r? @wesleywiser

cc: @rust-lang/rustdoc

rust-highfive · 2022-03-31T21:06:46Z

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

flip1995

This LGTM. Though I'm not familiar with the query system and if just adding a new key for Option<Symbol> is ok, so I leave that to Wesley to decide.

compiler/rustc_middle/src/query/mod.rs

xFrednet · 2022-05-03T15:36:40Z

Hey @wesleywiser, could you take a look at this PR? 🙃

wesleywiser

Thanks for the ping @xFrednet! This looks really good and I'm glad to see we were able to resolve the ICE while keeping that check in place. I left one small suggestion with the tests added and then we can merge.

src/test/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs

xFrednet · 2022-05-06T13:19:27Z

Thank you for the review! I've rebased on master as well. I've only changed the mentioned comment and updated the line numbers in the .stderr files. Everything else stayed the same 🙃

wesleywiser · 2022-05-06T15:13:23Z

Awesome!

@bors r+

bors · 2022-05-06T15:13:24Z

📌 Commit c26742d has been approved by wesleywiser

…esleywiser Support tool lints with the `#[expect]` attribute (RFC 2383) This PR fixes the ICE rust-lang#94953 by making the assert for converted expectation IDs conditional. Additionally, it moves the lint expectation check into a separate query to support rustdoc and other tools. On the way, I've also added some tests to ensure that the attribute works for Clippy and rustdoc lints. The number of changes comes from the long test file. This may look like a monster PR, this may smell like a monster PR and this may be a monster PR, but it's a harmless monster. 🦕 --- Closes: rust-lang#94953 cc: rust-lang#85549 r? `@wesleywiser` cc: `@rust-lang/rustdoc`

…esleywiser Support tool lints with the `#[expect]` attribute (RFC 2383) This PR fixes the ICE rust-lang#94953 by making the assert for converted expectation IDs conditional. Additionally, it moves the lint expectation check into a separate query to support rustdoc and other tools. On the way, I've also added some tests to ensure that the attribute works for Clippy and rustdoc lints. The number of changes comes from the long test file. This may look like a monster PR, this may smell like a monster PR and this may be a monster PR, but it's a harmless monster. 🦕 --- Closes: rust-lang#94953 cc: rust-lang#85549 r? ``@wesleywiser`` cc: ``@rust-lang/rustdoc``

…esleywiser Support tool lints with the `#[expect]` attribute (RFC 2383) This PR fixes the ICE rust-lang#94953 by making the assert for converted expectation IDs conditional. Additionally, it moves the lint expectation check into a separate query to support rustdoc and other tools. On the way, I've also added some tests to ensure that the attribute works for Clippy and rustdoc lints. The number of changes comes from the long test file. This may look like a monster PR, this may smell like a monster PR and this may be a monster PR, but it's a harmless monster. 🦕 --- Closes: rust-lang#94953 cc: rust-lang#85549 r? ```@wesleywiser``` cc: ```@rust-lang/rustdoc```

bors · 2022-05-07T13:19:34Z

⌛ Testing commit c26742d with merge 3076beb64cc568bead8924a7d63edf516ce1a662...

GuillaumeGomez · 2022-05-07T13:22:32Z

Failed in #96813:

 error: unresolved link to `unstable_expect_diagnostics`
   --> compiler/rustc_errors/src/lib.rs:429:15
    |
429 |     /// The [`unstable_expect_diagnostics`] should be empty when this struct is
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `unstable_expect_diagnostics` in scope
    |
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

error: unresolved link to `unstable_expect_diagnostics`
   --> compiler/rustc_errors/src/lib.rs:432:20
    |
432 |     /// check if [`unstable_expect_diagnostics`] is empty, if the expectation ids
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `unstable_expect_diagnostics` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

error: could not document `rustc_errors`

@bors r-

bors · 2022-05-08T12:43:12Z

✌️ @xFrednet can now approve this pull request

xFrednet · 2022-05-08T13:24:24Z

Thanks, I thought about using r=wesleywiser before, but was unsure if that would be okay 😅

@bors r=wesleywiser

bors · 2022-05-08T13:24:26Z

📌 Commit 332a9fa200f6e36fb8d5fbaf8e9fe0433562beea has been approved by wesleywiser

bors · 2022-05-08T13:33:06Z

⌛ Testing commit 332a9fa200f6e36fb8d5fbaf8e9fe0433562beea with merge 7e33efee9b7aba31953af392753e6f8bb682bd82...

bors · 2022-05-08T14:10:06Z

💔 Test failed - checks-actions

xFrednet · 2022-05-08T14:27:58Z

@bors r-

Co-authored-by: Philipp Krones <[email protected]>

xFrednet · 2022-05-08T16:08:56Z

Let's hope that third times is the charm.

@bors r=wesleywiser rollup=iffy

bors · 2022-05-08T16:08:57Z

📌 Commit 9516a40 has been approved by wesleywiser

bors · 2022-05-09T00:02:58Z

⌛ Testing commit 9516a40 with merge a571179...

bors · 2022-05-09T02:25:26Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing a571179 to master...

rust-timer · 2022-05-09T04:35:35Z

Finished benchmarking commit (a571179): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

…leywiser Support tool lints with the `#[expect]` attribute (RFC 2383) This PR fixes the ICE rust-lang#94953 by making the assert for converted expectation IDs conditional. Additionally, it moves the lint expectation check into a separate query to support rustdoc and other tools. On the way, I've also added some tests to ensure that the attribute works for Clippy and rustdoc lints. The number of changes comes from the long test file. This may look like a monster PR, this may smell like a monster PR and this may be a monster PR, but it's a harmless monster. 🦕 --- Closes: rust-lang#94953 cc: rust-lang#85549 r? `@wesleywiser` cc: `@rust-lang/rustdoc`

rust-highfive assigned wesleywiser Mar 31, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 31, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2022

xFrednet mentioned this pull request Mar 31, 2022

Implement expect attribute from RFC 2383, "Lint Reasons RFC" #85549

Closed

9 tasks

xFrednet added the F-lint_reasons `#![feature(lint_reasons)]` label Apr 1, 2022

flip1995 approved these changes Apr 5, 2022

View reviewed changes

compiler/rustc_middle/src/query/mod.rs Outdated Show resolved Hide resolved

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022

wesleywiser approved these changes May 5, 2022

View reviewed changes

src/test/ui/lint/rfc-2383-lint-reason/expect_tool_lint_rfc_2383.rs Outdated Show resolved Hide resolved

xFrednet force-pushed the rfc-2383-expect-query branch from 41208ff to c26742d Compare May 6, 2022 13:16

wesleywiser approved these changes May 6, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2022

GuillaumeGomez mentioned this pull request May 6, 2022

Rollup of 10 pull requests #96774

Closed

GuillaumeGomez mentioned this pull request May 6, 2022

Rollup of 10 pull requests #96775

Closed

GuillaumeGomez mentioned this pull request May 7, 2022

Rollup of 8 pull requests #96813

Closed

xFrednet mentioned this pull request May 8, 2022

Make bors ignore mentions in inline code blocks. rust-lang/homu#170

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 8, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2022

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2022

Fixed typo in docs and correct doc links

9516a40

Co-authored-by: Philipp Krones <[email protected]>

xFrednet force-pushed the rfc-2383-expect-query branch from 332a9fa to 9516a40 Compare May 8, 2022 15:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 8, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2022

bors merged commit a571179 into rust-lang:master May 9, 2022

rustbot added this to the 1.62.0 milestone May 9, 2022

xFrednet deleted the rfc-2383-expect-query branch June 3, 2022 23:00

nagisa mentioned this pull request Jun 13, 2022

x86_64-gnu-aux/x86_64-msvc-cargo: xsv test appears to fail spuriously #98068

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support tool lints with the `#[expect]` attribute (RFC 2383) #95542

Support tool lints with the `#[expect]` attribute (RFC 2383) #95542

xFrednet commented Mar 31, 2022 •

edited

Loading

rust-highfive commented Mar 31, 2022

flip1995 left a comment

xFrednet commented May 3, 2022

wesleywiser left a comment

xFrednet commented May 6, 2022 •

edited

Loading

wesleywiser commented May 6, 2022

bors commented May 6, 2022

bors commented May 7, 2022

GuillaumeGomez commented May 7, 2022

bors commented May 8, 2022

xFrednet commented May 8, 2022

bors commented May 8, 2022

bors commented May 8, 2022

bors commented May 8, 2022

This comment has been minimized.

xFrednet commented May 8, 2022

xFrednet commented May 8, 2022

bors commented May 8, 2022

bors commented May 9, 2022

bors commented May 9, 2022

rust-timer commented May 9, 2022

Support tool lints with the #[expect] attribute (RFC 2383) #95542

Support tool lints with the #[expect] attribute (RFC 2383) #95542

Conversation

xFrednet commented Mar 31, 2022 • edited Loading

rust-highfive commented Mar 31, 2022

flip1995 left a comment

Choose a reason for hiding this comment

xFrednet commented May 3, 2022

wesleywiser left a comment

Choose a reason for hiding this comment

xFrednet commented May 6, 2022 • edited Loading

wesleywiser commented May 6, 2022

bors commented May 6, 2022

bors commented May 7, 2022

GuillaumeGomez commented May 7, 2022

bors commented May 8, 2022

xFrednet commented May 8, 2022

bors commented May 8, 2022

bors commented May 8, 2022

bors commented May 8, 2022

This comment has been minimized.

xFrednet commented May 8, 2022

xFrednet commented May 8, 2022

bors commented May 8, 2022

bors commented May 9, 2022

bors commented May 9, 2022

rust-timer commented May 9, 2022

Support tool lints with the `#[expect]` attribute (RFC 2383) #95542

Support tool lints with the `#[expect]` attribute (RFC 2383) #95542

xFrednet commented Mar 31, 2022 •

edited

Loading

xFrednet commented May 6, 2022 •

edited

Loading