Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast_lowering: Stop wrapping ident matchers into groups #95571

Merged
merged 1 commit into from
Apr 2, 2022
Merged

ast_lowering: Stop wrapping ident matchers into groups #95571

merged 1 commit into from
Apr 2, 2022

Conversation

petrochenkov
Copy link
Contributor

The lowered forms goes to metadata, for example during encoding of macro definitions.
This is a missing part of #92472.

Fixes #95569
r? @Aaron1011

@petrochenkov
ast_lowering: Stop wrapping ident matchers into groups
a150fc2 
The lowered forms goes to metadata, for example during encoding of macro definitions
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 1, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2022
@petrochenkov petrochenkov mentioned this pull request Apr 1, 2022
Closed
@Aaron1011
Copy link
Member

Aaron1011 commented Apr 1, 2022 •
edited
Loading

It would be nice to de-duplicate this logic, but that can be done later.

r=me with CI passing

@petrochenkov
Copy link
Contributor Author

@bors r=Aaron1011

@bors
Copy link
Contributor

bors commented Apr 1, 2022

📌 Commit a150fc2 has been approved by Aaron1011

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2022
@bors
Copy link
Contributor

bors commented Apr 2, 2022

⌛ Testing commit a150fc2 with merge 07a461a...

@bors
Copy link
Contributor

bors commented Apr 2, 2022

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 07a461a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2022
@bors bors merged commit 07a461a into rust-lang:master Apr 2, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 2, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (07a461a): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@petrochenkov petrochenkov mentioned this pull request Apr 2, 2022
Closed
@CriesofCarrots CriesofCarrots mentioned this pull request Apr 15, 2022
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aaron1011 Aaron1011

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

Compilation failure after #92472 merged in
6 participants
@petrochenkov @Aaron1011 @bors @rust-timer @rust-highfive @rustbot