Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rustc_parse_format compile on stable #96558

Merged
merged 1 commit into from
May 3, 2022
Merged

Make rustc_parse_format compile on stable #96558

merged 1 commit into from
May 3, 2022

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 29, 2022

This allows it to be used by lightweight formatting systems and may allow it to be used by rust-analyzer.

@bjorn3 bjorn3 added A-parser Area: The parsing of Rust source code to an AST. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2022
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2022
@bjorn3
Copy link
Member Author

bjorn3 commented Apr 29, 2022

I'm not entirely happy about the effect of having to duplicate InnerSpan between rustc_span and rustc_parse_format.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidtwco
Copy link
Member

I'm not entirely happy about the effect of having to duplicate InnerSpan between rustc_span and rustc_parse_format.

I guess a tiny rustc_inner_span crate could be added to contain just this and rustc_span and rustc_parse_format could depend on it, but I'm not sure it's worth it.

r=me if you are happy to land this as-is

@bjorn3
Make rustc_parse_format compile on stable
d33140d 
This allows it to be used by lightweight formatting systems and may
allow it to be used by rust-analyzer.
@bjorn3
Copy link
Member Author

bjorn3 commented May 3, 2022

Yeah, that is probably not worth it. Squashed the clippy fix commit into the main commit. I did like to do a perf run first as I may have accidentally increased the amount of Symbol::intern calls.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 3, 2022
@bors
Copy link
Contributor

bors commented May 3, 2022

⌛ Trying commit d33140d with merge b26869b840546ef3956907d70a0583f41280919d...

@bjorn3
Copy link
Member Author

bjorn3 commented May 3, 2022

Looks like bors didn't notice that the try job succeeded.

@rust-timer build b26869b840546ef3956907d70a0583f41280919d

@rust-timer
Copy link
Collaborator

Queued b26869b840546ef3956907d70a0583f41280919d with parent 468492c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b26869b840546ef3956907d70a0583f41280919d): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 3, 2022
@bjorn3
Copy link
Member Author

bjorn3 commented May 3, 2022

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented May 3, 2022

📌 Commit d33140d has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2022
@bors
Copy link
Contributor

bors commented May 3, 2022

⌛ Testing commit d33140d with merge e1b71fe...

@bors
Copy link
Contributor

bors commented May 3, 2022

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing e1b71fe to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 3, 2022
@bors bors merged commit e1b71fe into rust-lang:master May 3, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 3, 2022
@bors bors mentioned this pull request May 3, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e1b71fe): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@bjorn3 bjorn3 deleted the librarify_parse_format branch May 4, 2022 20:14
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 5, 2022
@bors
Auto merge of rust-lang#96558 - bjorn3:librarify_parse_format, r=davi…
8be86fc 
…dtwco

Make rustc_parse_format compile on stable

This allows it to be used by lightweight formatting systems and may allow it to be used by rust-analyzer.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-parser Area: The parsing of Rust source code to an AST. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bjorn3 @rust-highfive @rust-log-analyzer @davidtwco @rust-timer @bors @rustbot