Add regression test for #96395 #96950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
I will approve this, but also I hope this test isn't as flaky as it is in glacier. @bors r+ |
|
📌 Commit dc87ad2 has been approved by |
bors
added
S-waiting-on-bors
|
further info: it became flaky around 2022-04-04 |
|
@bors r- I want to look into the ICE. If it really is this flaky, having it in CI will only frustrate people, not actually make sure it doesn't regress again |
bors
added
S-waiting-on-author
|
I opened #96965 which should fix both the ICE and the flakiness |
|
Great! Do you want to keep this open for a while to see that PR fixes the issue actually?
I'm going to mark this blocked until we can say "it's okay". |
JohnTitor
added
S-blocked
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 13, 2022
Gracefully handle normalization failures in the prospective inliner cycle detector Preliminary work for adding the regression test in rust-lang#96950 to our test suite (it was flaky on glacier). If this PR solves the flakiness on glacier, we can then merge rust-lang#96950
|
It has been a fair while since #96965 and each nightly since then no longer ICEs, I think it did the trick 👍 |
|
Thanks for confirming it! Moving back to |
JohnTitor
added
S-waiting-on-review
|
@bors r=compiler-errors,oli-obk |
|
Hm, bors ignored it? |
|
📌 Commit dc87ad2 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 28, 2022
…rrors,oli-obk Add regression test for rust-lang#96395 Closes rust-lang#96395 This repeats "fixed" and "ICE", see rust-lang/glacier#1243 (comment) I think it's good to add a test before regressing again. r? `@compiler-errors` for quick reviiew cc `@oli-obk` you might want to check as you're familiar with MIR
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2022
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#96950 (Add regression test for rust-lang#96395) - rust-lang#97028 (Add support for embedding pretty printers via `#[debugger_visualizer]` attribute) - rust-lang#97478 (Remove FIXME on `ExtCtxt::fn_decl()`) - rust-lang#97479 (Make some tests check-pass) - rust-lang#97482 (ptr::invalid is not equivalent to a int2ptr cast) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96395
This repeats "fixed" and "ICE", see rust-lang/glacier#1243 (comment)
I think it's good to add a test before regressing again.
r? @compiler-errors for quick reviiew
cc @oli-obk you might want to check as you're familiar with MIR